Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme benchmark improvements #14347

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rubvs
Copy link

@rubvs rubvs commented Oct 11, 2024

Motivation/summary

The current version of README in testing/benchmark is repetitive and can be confusing. This PR is an attempt to try and resolve some of these redundancies by:

  • Leveraging a bullet-point format
  • Defining defaults and environment variable overrides
  • Making it clear when to use specific make functions

@rubvs rubvs requested a review from a team as a code owner October 11, 2024 19:06
Copy link
Contributor

mergify bot commented Oct 11, 2024

This pull request does not have a backport label. Could you fix it @rubvs? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Oct 11, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 11, 2024
@rubvs rubvs requested review from endorama and 1pkg October 11, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants