Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functionaltests: wait for aggregation data steams #15317

Closed
wants to merge 2 commits into from

Conversation

endorama
Copy link
Member

@endorama endorama commented Jan 21, 2025

Motivation/summary

Today's functional-tests run failed due to executing the first data stream check before all data stream we expect to be present were there.
This may happen due to the 1m aggregation data streams being not yet created if the data stream check happens too fast.
Ideally this problem was fixed with the initial implementation, but it only reduced its occurrence.
This PR introduces an additional check in RunBlocking to verify if other dta strea'ms are present, ignoring the document count (which is problematic for aggregation data streams).

Checklist

How to test these changes

https://github.com/elastic/apm-server/actions/runs/12892900589

Related issues

#14100

If document count value in the expected map is lower than 0 the
doc count value is ignored and the data stream is only checked for presence.
We only check for the 1 minute interval as is the only one affecting
ingestion, being close in time with it.
@endorama endorama requested a review from a team as a code owner January 21, 2025 16:31
Copy link
Contributor

mergify bot commented Jan 21, 2025

This pull request does not have a backport label. Could you fix it @endorama? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Jan 21, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 21, 2025
@endorama
Copy link
Member Author

We decided to take a different approach than what is in this PR. This approach has been implemented in #15356.

I'm closing this PR as superseded by the other one. Thanks @kruskall for the review 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants