Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add some OTel attributes for DynamoDB spec #817

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

docs: add some OTel attributes for DynamoDB spec #817

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce14983
docs: add some OTel attributes for DynamoDB spec
david-luna Jul 18, 2023
d82ccda
chore: remove TODO mark
david-luna Jul 18, 2023
cf90980
chore: fix format on table_list spec
david-luna Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions specs/agents/tracing-instrumentation-db.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ The following fields are relevant for database and datastore spans. Where possib
| __**service.target._**__ |<hr/>|<hr/>|
|`_.type`| `dynamodb` ||
|`_.name`| e.g. `us-east-1` | Use same value as `context.db.instance` |
| __**otel.attributes._**__ |<hr/>|<hr/>|
TODO
david-luna marked this conversation as resolved.
Show resolved Hide resolved
|`_["aws.dynamodb.table_names"]`| `[ MyTable ]` | The table names, if available. See [OTel Semantic Conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.23.0/specification/trace/semantic_conventions/instrumentation/aws-sdk.md). Note: this must be a single dotted string key in the `otel.attributes` mapping -- for example `{"otel": {"attributes": {"aws.dynamodb.table_names": "[ MyTable ]"}}}` -- and *not* a nested object. |
david-luna marked this conversation as resolved.
Show resolved Hide resolved
|`_["aws.dynamodb.projection"]`| `Field1, Field2` | The value of the `ProjectionExpression` request parameter, if available. See [OTel Semantic Conventions](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.23.0/specification/trace/semantic_conventions/instrumentation/aws-sdk.md). Note: this must be a single dotted string key in the `otel.attributes` mapping -- for example `{"otel": {"attributes": {"aws.dynamodb.projection": "Field1, Field2"}}}` -- and *not* a nested object. |

### AWS S3

Expand Down