Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outcome definition in error-tracking.md #824

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gregkalapos
Copy link
Contributor

In error-tracking.md the definition of how outcome is set contradicted what we define in tracing-transactions.md and in tracing-spans.md, especially the following:

Tracking an error that's related to a transaction does not impact its outcome.

This PR changes error-tracking.md to make it match the outcome definition from other parts of the spec (see links above). I think most agents already do this according to tracing-transactions.md and tracing-spans.md - so I expect we won't need to change any implementation in a specific agent.

If that's not the case, please raise it and let's discuss.

  • Create PR as draft
  • Approval by at least one other agent
  • Mark as Ready for Review (automatically requests reviews from all agents and PM via CODEOWNERS)
    • Remove PM from reviewers if impact on product is negligible
    • Remove agents from reviewers if the change is not relevant for them
  • Merge after 2 business days passed without objections
    To auto-merge the PR, add /schedule YYYY-MM-DD to the PR description.

Fix `outcome` description to match other parts of the spec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant