Skip to content

Revert "Update elastic-agent-client and rename control proto package to cproto" #19825

Revert "Update elastic-agent-client and rename control proto package to cproto"

Revert "Update elastic-agent-client and rename control proto package to cproto" #19825

Triggered via pull request May 30, 2024 13:09
Status Failure
Total duration 5m 56s
Artifacts

golangci-lint.yml

on: pull_request
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

32 errors and 7 warnings
lint (darwin): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L12
SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
lint (darwin): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L605
Error return value of `c.agentProc.StopWait` is not checked (errcheck)
lint (darwin): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L667
comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
lint (darwin): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L717
comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
lint (darwin): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L830
comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
lint (darwin): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L844
Error return value of `fileLock.Unlock` is not checked (errcheck)
lint (darwin): x-pack/elastic-agent/pkg/agent/control/server/server.go#L155
error is not nil (line 153) but it returns nil (nilerr)
lint (darwin): x-pack/elastic-agent/pkg/agent/control/server/server.go#L238
(*net/http.Client).Get must not be called (noctx)
lint (darwin): x-pack/elastic-agent/pkg/core/server/server.go#L151
G402: TLS MinVersion too low. (gosec)
lint (darwin): x-pack/elastic-agent/pkg/core/server/server.go#L983
comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
lint (linux)
The job was canceled because "darwin" failed.
lint (linux): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L12
SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
lint (linux): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L605
Error return value of `c.agentProc.StopWait` is not checked (errcheck)
lint (linux): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L667
comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
lint (linux): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L717
comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
lint (linux): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L830
comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
lint (linux): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L844
Error return value of `fileLock.Unlock` is not checked (errcheck)
lint (linux): x-pack/elastic-agent/pkg/agent/control/server/server.go#L155
error is not nil (line 153) but it returns nil (nilerr)
lint (linux): x-pack/elastic-agent/pkg/agent/control/server/server.go#L238
(*net/http.Client).Get must not be called (noctx)
lint (linux): x-pack/elastic-agent/pkg/core/server/server.go#L151
G402: TLS MinVersion too low. (gosec)
lint (linux): x-pack/elastic-agent/pkg/core/server/server.go#L983
comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
lint (windows)
The job was canceled because "darwin" failed.
lint (windows): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L12
SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package [io] or package [os], and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
lint (windows): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L605
Error return value of `c.agentProc.StopWait` is not checked (errcheck)
lint (windows): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L667
comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
lint (windows): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L717
comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
lint (windows): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L830
comparing with != will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
lint (windows): x-pack/elastic-agent/pkg/agent/cmd/enroll_cmd.go#L844
Error return value of `fileLock.Unlock` is not checked (errcheck)
lint (windows): x-pack/elastic-agent/pkg/agent/control/server/server.go#L155
error is not nil (line 153) but it returns nil (nilerr)
lint (windows): x-pack/elastic-agent/pkg/agent/control/server/server.go#L238
(*net/http.Client).Get must not be called (noctx)
lint (windows): x-pack/elastic-agent/pkg/core/server/server.go#L151
G402: TLS MinVersion too low. (gosec)
lint (windows): x-pack/elastic-agent/pkg/core/server/server.go#L983
comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error (errorlint)
lint (darwin)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v3, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
lint (darwin)
Unexpected input(s) 'skip-go-installation', valid inputs are ['version', 'args', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-pkg-cache', 'skip-build-cache', 'install-mode']
lint (darwin)
Unexpected input(s) 'skip-go-installation', valid inputs are ['version', 'args', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-pkg-cache', 'skip-build-cache', 'install-mode']
lint (linux)
Unexpected input(s) 'skip-go-installation', valid inputs are ['version', 'args', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-pkg-cache', 'skip-build-cache', 'install-mode']
lint (linux)
Unexpected input(s) 'skip-go-installation', valid inputs are ['version', 'args', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-pkg-cache', 'skip-build-cache', 'install-mode']
lint (windows)
Unexpected input(s) 'skip-go-installation', valid inputs are ['version', 'args', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-pkg-cache', 'skip-build-cache', 'install-mode']
lint (windows)
Unexpected input(s) 'skip-go-installation', valid inputs are ['version', 'args', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-pkg-cache', 'skip-build-cache', 'install-mode']