Skip to content

Commit

Permalink
Add integration test
Browse files Browse the repository at this point in the history
  • Loading branch information
belimawr committed Jan 16, 2024
1 parent f6dce06 commit dcde0e5
Show file tree
Hide file tree
Showing 2 changed files with 136 additions and 1 deletion.
131 changes: 131 additions & 0 deletions filebeat/tests/integration/events_log_file_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,131 @@
// Licensed to Elasticsearch B.V. under one or more contributor
// license agreements. See the NOTICE file distributed with
// this work for additional information regarding copyright
// ownership. Elasticsearch B.V. licenses this file to you under
// the Apache License, Version 2.0 (the "License"); you may
// not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

//go:build integration

package integration

import (
"fmt"
"os"
"path/filepath"
"strings"
"testing"
"time"

"github.com/stretchr/testify/require"

"github.com/elastic/beats/v7/libbeat/tests/integration"
)

var eventsLogFileCfg = `
filebeat.inputs:
- type: filestream
id: filestream-input-id
enabled: true
parsers:
- ndjson:
target: ""
overwrite_keys: true
expand_keys: true
add_error_key: true
ignore_decoding_error: false
paths:
- %s
output:
elasticsearch:
hosts:
- localhost:9200
protocol: http
username: admin
password: testing
logging:
level: debug
files:
events:
files:
name: filebeat-events-data
`

func TestEventsLoggerESOutput(t *testing.T) {
// First things first, ensure ES is running and we can connect to it.
// If ES is not running, the test will timeout and the only way to know
// what caused it is going through Filebeat's logs.
integration.EnsureESIsRunning(t)

filebeat := integration.NewBeat(
t,
"filebeat",
"../../filebeat.test",
)

logFilePath := filepath.Join(filebeat.TempDir(), "log.log")
filebeat.WriteConfigFile(fmt.Sprintf(eventsLogFileCfg, logFilePath))

logFile, err := os.Create(logFilePath)
if err != nil {
t.Fatalf("could not create file '%s': %s", logFilePath, err)
}

logFile.WriteString(`

Check failure on line 86 in filebeat/tests/integration/events_log_file_test.go

View workflow job for this annotation

GitHub Actions / lint (windows)

Error return value of `logFile.WriteString` is not checked (errcheck)
{"message":"foo bar","int":10,"string":"str"}
{"message":"another message","int":20,"string":"str2"}
{"message":"index failure","int":"not a number","string":10}
{"message":"second index failure","int":"not a number","string":10}
`)
if err := logFile.Sync(); err != nil {
t.Fatalf("could not sync log file '%s': %s", logFilePath, err)
}
if err := logFile.Close(); err != nil {
t.Fatalf("could not close log file '%s': %s", logFilePath, err)
}

filebeat.Start()

// Wait for a log entry that indicates an entry in the events
// logger file.
msg := "Cannot index event (status=400)"
require.Eventually(t, func() bool {
return filebeat.LogContains(msg)
}, time.Minute, 100*time.Millisecond,
fmt.Sprintf("String '%s' not found on Filebeat logs", msg))

glob := filepath.Join(filebeat.TempDir(), "filebeat-events-data*.ndjson")
files, err := filepath.Glob(glob)
if err != nil {
t.Fatalf("could not read files matching glob '%s': %s", glob, err)
}
if len(files) != 1 {
t.Fatalf("there must be only one file matching the glob '%s', found: %s", glob, files)
}

eventsLogFile := files[0]
data, err := os.ReadFile(eventsLogFile)
if err != nil {
t.Fatalf("could not read '%s': %s", eventsLogFile, err)
}

strData := string(data)
eventMsg := "not a number"
if !strings.Contains(strData, eventMsg) {
t.Errorf("expecting to find '%s' on '%s'", eventMsg, eventsLogFile)
t.Errorf("Contents:\n%s", strData)
t.FailNow()
}
}
6 changes: 5 additions & 1 deletion libbeat/tests/integration/framework.go
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,11 @@ func (b *BeatProc) WriteConfigFile(cfg string) {
// when the test ends.
func (b *BeatProc) openLogFile() *os.File {
t := b.t
glob := fmt.Sprintf("%s-*.ndjson", filepath.Join(b.tempDir, b.beatName))
// Beats can produce two different log files, to make sure we're
// reading the normal one we add the year to the glob. The default
// log file name looks like: filebeat-20240116.ndjson
year := time.Now().Year()
glob := fmt.Sprintf("%s-%d*.ndjson", filepath.Join(b.tempDir, b.beatName), year)
files, err := filepath.Glob(glob)
if err != nil {
t.Fatalf("could not expand log file glob: %s", err)
Expand Down

0 comments on commit dcde0e5

Please sign in to comment.