Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo error corrected and inconsistency removed! #34331

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AgniveshChaubey
Copy link

What does this PR do?

This PR fixes the typo error and inconsistency mentioned in #34291

Before:
"description": "Overview dashboard por powershell module."
"title": "[Winlogbeat powershell] Overview",

After:
"description": "Overview dashboard for PowerShell module.",
"title": "[Winlogbeat PowerShell] Overview",

Signed-off by : Agnivesh Chaubey [email protected]

@AgniveshChaubey AgniveshChaubey requested a review from a team as a code owner January 20, 2023 16:46
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 20, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @AgniveshChaubey? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-26T21:41:11.811+0000

  • Duration: 37 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 336
Skipped 0
Total 336

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6
Copy link
Contributor

efd6 commented Jan 22, 2023

/test

@AgniveshChaubey
Copy link
Author

/test

can you please explain a bit more about what are you referring to?

@efd6
Copy link
Contributor

efd6 commented Jan 26, 2023

@AgniveshChaubey Only CI-approved contributors can start builds. To get your build started, I asked the builder to start with the /test command.

@efd6
Copy link
Contributor

efd6 commented Jan 26, 2023

/test

@efd6 efd6 added Winlogbeat Team:Security-External Integrations 8.7-candidate and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 26, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Comment on lines 410 to 412
"version": "WzIxNTQsMl0="
} No newline at end of file
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind reverting this addition please.

Copy link
Contributor

mergify bot commented Nov 14, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b typo-error-correction/#34291-1 upstream/typo-error-correction/#34291-1
git merge upstream/main
git push upstream typo-error-correction/#34291-1

1 similar comment
Copy link
Contributor

mergify bot commented Feb 5, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b typo-error-correction/#34291-1 upstream/typo-error-correction/#34291-1
git merge upstream/main
git push upstream typo-error-correction/#34291-1

Copy link
Contributor

mergify bot commented Feb 5, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @AgniveshChaubey? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@narph narph added Team:Security-Windows Platform Windows Platform Team in Security Solution and removed Team:Security-External Integrations labels Feb 8, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

Copy link
Contributor

mergify bot commented Dec 26, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 26, 2024
Copy link
Contributor

mergify bot commented Dec 26, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b typo-error-correction/#34291-1 upstream/typo-error-correction/#34291-1
git merge upstream/main
git push upstream typo-error-correction/#34291-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.7-candidate backport-8.x Automated backport to the 8.x branch with mergify Team:Security-Windows Platform Windows Platform Team in Security Solution Winlogbeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants