Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filebeat/module/mysql: add authentication message parsing and related.ip & related.user fields #34810

Merged
merged 12 commits into from
Mar 29, 2023

Conversation

leweafan
Copy link
Contributor

What does this PR do?

Adds new patterns, authentication message parsing and related.ip & related.user fields

Why is it important?

Parsing should be ECS compliant and authentication messages important for SIEM

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 12, 2023
@botelastic
Copy link

botelastic bot commented Mar 12, 2023

This pull request doesn't have a Team:<team> label.

@mergify
Copy link
Contributor

mergify bot commented Mar 12, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @leweafan? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-28T23:35:18.512+0000

  • Duration: 73 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 7585
Skipped 747
Total 8332

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@leweafan leweafan marked this pull request as ready for review March 12, 2023 20:34
@leweafan leweafan requested a review from a team as a code owner March 12, 2023 20:34
@efd6
Copy link
Contributor

efd6 commented Mar 13, 2023

/test

@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mysql_new upstream/mysql_new
git merge upstream/main
git push upstream mysql_new

@leweafan
Copy link
Contributor Author

Can any one help with review?

@leweafan
Copy link
Contributor Author

@tetianakravchenko can I ask you to help with this one too?

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also resolve the merge conflict.

filebeat/module/mysql/error/ingest/pipeline.yml Outdated Show resolved Hide resolved
filebeat/module/mysql/error/ingest/pipeline.yml Outdated Show resolved Hide resolved
filebeat/module/mysql/error/ingest/pipeline.yml Outdated Show resolved Hide resolved
filebeat/module/mysql/error/ingest/pipeline.yml Outdated Show resolved Hide resolved
filebeat/module/mysql/error/ingest/pipeline.yml Outdated Show resolved Hide resolved
filebeat/module/mysql/slowlog/ingest/pipeline.json Outdated Show resolved Hide resolved
filebeat/module/mysql/slowlog/ingest/pipeline.json Outdated Show resolved Hide resolved
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@efd6
Copy link
Contributor

efd6 commented Mar 28, 2023

/test

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit 2c7b959 into elastic:main Mar 29, 2023
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
3 participants