[Metricbeat][GCP] instance event should contain all resource and metric labels

[kwinstonix]

• Bug

What does this PR do?

Why is it important?

gcp.labels.resource and gcp.labels.metrics should keep original timeSeries labels, that should be a fixed behavior for all metircs. We should not filter out some labels: instance_name, instance_id, zone, project_id.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

#29573

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kwinstonix? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-06-29T13:17:57.911+0000

• Duration: 50 min 54 sec

Test stats 🧪

Test	Results
Failed	0
Passed	1533
Skipped	90
Total	1623

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[tommyers-elastic]

hey @kwinstonix. the intention here is that any metadata that can be mapped to ECS fields is done so. the four fields mentioned here are included in events in the following fields:

instance_name => cloud.instance.name
instance_id => cloud.instance.id
zone => cloud.availability_zone
project_id => cloud.account.id

this is typical behaviour. what is the rationale behind keep original timeSeries labels, that should be a fixed behavior for all metircs ?

[kwinstonix]

@tommyers-elastic ,

1. GCP timeseries API response data model is clear. https://cloud.google.com/monitoring/api/ref_v3/rest/v3/TimeSeries

2. It maybe confusing that some metric events have no gcp.labels.resource and gcp.labels.metrics field, or region and zone label are missing . That two labels clearly indicate which resource metric belongs to. The purpose of these two labels is the same as the aws.dimensions in aws metric event.

3. Event data model should be fixed

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gcp_instance_labels upstream/gcp_instance_labels
git merge upstream/main
git push upstream gcp_instance_labels

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kwinstonix? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gcp_instance_labels upstream/gcp_instance_labels
git merge upstream/main
git push upstream gcp_instance_labels

[mergify]

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gcp_instance_labels upstream/gcp_instance_labels
git merge upstream/main
git push upstream gcp_instance_labels