-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Enable awscloudwatch input to collect logs from linked source accounts #36645
[Filebeat] Enable awscloudwatch input to collect logs from linked source accounts #36645
Conversation
For cross account monitoring, we need to use the log group ARN, instead of log group name in order to retreive logs from outside the monitoring account. This change used ARN throughout (but still requires a conversion back to get the 'plain' log group name to construct the log metadata at the end - not ideal).
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
… accounts." This reverts commit 844df38.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me. Maybe we can add some documentation about this feature too in https://github.com/elastic/beats/blob/main/x-pack/filebeat/docs/inputs/input-aws-cloudwatch.asciidoc?
This pull request is now in conflicts. Could you fix it? 🙏
|
1 similar comment
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
May I check when can this PR be done? waiting for this feature.. |
Hi @kaiyan-sheng, it would be amazing if this PR could get completed! We are very keen to use this feature to collect CW logs from multiple accounts with a centralized elastic agent. thank you! |
@tommyers-elastic I'm closing this PR since we've merged @Kavindu-Dodan's instead :) Thank you!! |
Pull request was closed
When
log_group_arn
is configured, use it directly, instead of parsing the log group name and using that instead. This allows log collection from linked source accounts.In order to 'fully' support cross account collection with log group prefixes, we need to add additional configuration options to allow
DescribeLogGroups
to discover log groups in linked accounts. This change will come separately.CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Fixes #36642