Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.10](backport #36650) winlogbeat/sys/wineventlog: fix unsafe pointer use #36663

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 22, 2023

This is an automatic backport of pull request #36650 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Fix the use of pointer to uintptr conversions to comply with the unsafe.Pointer
rules. In particular, the code previously was not making conversions from a *T
to uintptr in the call expression as required by rule (4) Conversion of a
Pointer to a uintptr when calling syscall.Syscall[1].

[1]https://pkg.go.dev/unsafe#Pointer

(cherry picked from commit 0ad4264)
@mergify mergify bot requested a review from a team as a code owner September 22, 2023 20:40
@mergify mergify bot added the backport label Sep 22, 2023
@mergify mergify bot assigned efd6 Sep 22, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 22, 2023
@botelastic
Copy link

botelastic bot commented Sep 22, 2023

This pull request doesn't have a Team:<team> label.

@efd6 efd6 enabled auto-merge (squash) September 22, 2023 20:47
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-22T20:46:25.555+0000

  • Duration: 77 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 28159
Skipped 2015
Total 30174

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 merged commit 27a8db8 into 8.10 Sep 22, 2023
84 of 86 checks passed
@efd6 efd6 deleted the mergify/bp/8.10/pr-36650 branch September 22, 2023 22:03
@elasticmachine
Copy link
Collaborator

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-22T20:40:27.616+0000

  • Duration: 87 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 26009
Skipped 1987
Total 27996

Steps errors 1

Expand to view the steps failures

x-pack/filebeat-goIntegTest - mage goIntegTest
  • Took 6 min 50 sec . View more details here
  • Description: mage goIntegTest

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants