Enhancement: Do not write index template if nothing changed.

[nutmos]

Proposed commit message

• Reduce Elasticsearch PUT command by GET template and compare with the template that beat intended to overwrite. Only apply when the template content is changed.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

• [ ]

How to test this PR locally

Related issues

• Closes Do not overwrite index template if it has not changed #29202

Use cases

Screenshots

Logs

[cla-checker-service]

💚 CLA has been signed

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @nutmos? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

[elasticmachine]

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-09-30T14:39:21.111+0000

• Duration: 5 min 51 sec

Steps errors

Expand to view the steps failures

Load a resource file from a library

• Took 0 min 0 sec . View more details here
• Description: approval-list/elastic/beats.yml

Error signal

• Took 0 min 0 sec . View more details here
• Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/nutmos return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/nutmos : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/nutmos : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/orgs/members#check-organization-membership-for-a-user"}

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[rdner]

@nutmos thank you for your contribution!

Please fix the linter issues.

@fearful-symmetry would this conflict with any changes you're currently working on?

[rdner]

@nutmos What steps did you take for testing?

[fearful-symmetry]

So, this probably won't cause a merge conflict with #36649. Probably...

[nutmos]

@rdner Resolved. I'll provide the testing later this week.

[pierrehilbert]

Hey @nutmos, did you find time for the testing part?

[pierrehilbert]

Sorry for this new ping @nutmos, but did you find time for the testing part?

[nutmos]

Sorry for this new ping @nutmos, but did you find time for the testing part?

Sorry I have no time for the testing part yet.

[nutmos]

I just have a time to test this PR. The method reflect.DeepEqual doesn't work well. I need to find another method to check this case.

[pierrehilbert]

Hey @nutmos
I'm putting this one back to draft for now.

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @nutmos? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit