Make test output honor output.elasticsearch.proxy_url #36715

sakurai-youhei · 2023-10-02T08:41:06Z

This PR will fix the part of #24751 related to Elasticsearch. The code here depends on elastic/elastic-agent-libs#154.

$ ./filebeat test output -E output.elasticsearch.username=admin -E output.elasticsearch.password=testing -E output.elasticsearch.hosts=http://localhost:9200 -E output.elasticsearch.proxy_url=http://proxy:testing@localhost:3128
elasticsearch: http://localhost:9200...
  parse url... OK
  proxy...
    parse host... OK
    dns lookup... OK
    addresses: 127.0.0.1
    dial up... OK
  connection...
    proxy... OK
    dial up... OK
  TLS... WARN secure connection disabled
  talk to server... OK
  version: 8.11.0-SNAPSHOT

Proposed commit message

See title

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation - no change is needed.
I have made corresponding change to the default configuration files - no change is needed.
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

hidden because this section is no longer valid

## Author's Checklist

Mark this PR ready for review once Make test output honor output.logstash.proxy_url elastic-agent-libs#154 is merged.

How to test this PR locally

sakurai@wsl-debian:~/go/src/github.com/elastic/beats/libbeat$ go test -v ./tests/integration... -tags integration -run TestCmdTestOutput
=== RUN   TestCmdTestOutput
--- PASS: TestCmdTestOutput (0.34s)
=== RUN   TestCmdTestOutputBadHost
--- PASS: TestCmdTestOutputBadHost (2.29s)
=== RUN   TestCmdTestOutputProxy
--- PASS: TestCmdTestOutputProxy (0.45s)
=== RUN   TestCmdTestOutputProxyBadHost
--- PASS: TestCmdTestOutputProxyBadHost (0.34s)
=== RUN   TestCmdTestOutputBadProxy
--- PASS: TestCmdTestOutputBadProxy (2.28s)
=== RUN   TestCmdTestOutputBadProxyDisable
--- PASS: TestCmdTestOutputBadProxyDisable (0.35s)
PASS
ok      github.com/elastic/beats/v7/libbeat/tests/integration   6.046s

Related issues

Use cases

I frequently rely on test output command for troubleshooting, so its reliability is key.

Fixes elastic#24751

mergify · 2023-10-02T08:41:43Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @sakurai-youhei? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

elasticmachine · 2023-10-02T09:52:07Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-11-01T23:16:48.418+0000
Duration: 134 min 33 sec

Test stats 🧪

Test	Results
Failed	0
Passed	28627
Skipped	2015
Total	30642

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

sakurai-youhei · 2023-10-04T01:39:55Z

~~I will complete remaining works in this PR once the depending elastic/elastic-agent-libs#154 will have been merged.~~

libbeat/esleg/eslegclient/connection.go

belimawr · 2023-10-27T07:39:44Z

libbeat/esleg/eslegclient/connection.go

+			if proxyURL := conn.Transport.Proxy.URL; proxyURL == nil || conn.Transport.Proxy.Disable {
+				dialer = transport.TestNetDialer(d, conn.Transport.Timeout)
+			} else {
+				dialer = transport.NetDialer(conn.Transport.Timeout)


I'm trying to understand the logic here. Why is the choice between the TestNetDialer and NetDialer is based on the proxy URL/proxy being enabled?

@belimawr That's because the TCP connectivity has already been examined by TestNetDialer if the peer is the proxy server. Thanks to your comment, I realize there's much room to improve readability in the Test function. I hope the new one is self-explanatory enough.

Co-authored-by: Tiago Queiroz <[email protected]>

mergify · 2023-11-01T14:56:12Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b honor-elasticsearch-proxy_url upstream/honor-elasticsearch-proxy_url
git merge upstream/main
git push upstream honor-elasticsearch-proxy_url

mergify · 2023-11-30T20:05:44Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b honor-elasticsearch-proxy_url upstream/honor-elasticsearch-proxy_url
git merge upstream/main
git push upstream honor-elasticsearch-proxy_url

elasticmachine · 2023-12-05T05:35:10Z

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-12-05T03:10:23.802+0000
Duration: 144 min 30 sec

Test stats 🧪

Test	Results
Failed	1
Passed	28716
Skipped	2015
Total	30732

Test errors

Expand to view the tests failures

`Build&Test / filebeat-pythonIntegTest / test_shutdown – filebeat.tests.system.test_shutdown.Test`

Expand to view the error details

 AssertionError: Expected exit code to be 0, but it was -15

Expand to view the stacktrace

 self = <test_shutdown.Test testMethod=test_shutdown>

    @unittest.skipIf(platform.platform().startswith("Windows-7"),
                     "Flaky test: https://github.com/elastic/beats/issues/22795")
    def test_shutdown(self):
        """
        Test starting and stopping Filebeat under load.
        """
    
        self.nasa_logs()
    
        self.render_config_template(
            path=os.path.abspath(self.working_dir) + "/log/*",
            ignore_older="1h"
        )
        for i in range(1, 5):
            proc = self.start_beat(logging_args=["-e", "-v"])
            time.sleep(.5)
>           proc.check_kill_and_wait()

tests/system/test_shutdown.py:31: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../libbeat/tests/system/beat/beat.py:153: in check_kill_and_wait
    return self.check_wait(exit_code=exit_code)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <beat.beat.Proc object at 0x7f51ddd5ab30>, exit_code = 0

    def check_wait(self, exit_code=0):
        """
        check_wait waits for the process to exit, and checks the return code of the process
        """
        actual_exit_code = self.wait()
>       assert actual_exit_code == exit_code, f"Expected exit code to be {exit_code}, but it was {actual_exit_code}"
E       AssertionError: Expected exit code to be 0, but it was -15

../libbeat/tests/system/beat/beat.py:133: AssertionError

Steps errors

Expand to view the steps failures

`filebeat-pythonIntegTest - mage pythonIntegTest`

Took 41 min 16 sec . View more details here
Description: mage pythonIntegTest

`filebeat-pythonIntegTest - mage pythonIntegTest`

Took 38 min 58 sec . View more details here
Description: mage pythonIntegTest

`filebeat-pythonIntegTest - mage pythonIntegTest`

Took 39 min 44 sec . View more details here
Description: mage pythonIntegTest

`Error signal`

Took 0 min 0 sec . View more details here
Description: Error 'hudson.AbortException: script returned exit code 1'

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

Name: Build&Test / filebeat-pythonIntegTest / test_shutdown – filebeat.tests.system.test_shutdown.Test

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

mergify · 2023-12-07T17:18:29Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b honor-elasticsearch-proxy_url upstream/honor-elasticsearch-proxy_url
git merge upstream/main
git push upstream honor-elasticsearch-proxy_url

elasticmachine · 2023-12-08T08:53:43Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-12-08T06:42:07.756+0000
Duration: 131 min 20 sec

Test stats 🧪

Test	Results
Failed	0
Passed	28725
Skipped	2015
Total	30740

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

mergify · 2023-12-12T14:08:27Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b honor-elasticsearch-proxy_url upstream/honor-elasticsearch-proxy_url
git merge upstream/main
git push upstream honor-elasticsearch-proxy_url

elasticmachine · 2023-12-17T03:25:39Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-12-17T01:10:24.275+0000
Duration: 135 min 57 sec

Test stats 🧪

Test	Results
Failed	0
Passed	28737
Skipped	2015
Total	30752

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

sakurai-youhei · 2024-10-22T11:06:16Z

I'm closing this PR to clean up my PR list. Please feel free to reopen PR and/or ping me anytime.

Make test output honor output.elasticsearch.proxy_url

268a6b7

Fixes elastic#24751

sakurai-youhei added the bug label Oct 2, 2023

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 2, 2023

mergify bot assigned sakurai-youhei Oct 2, 2023

sakurai-youhei mentioned this pull request Oct 2, 2023

Make test output honor output.logstash.proxy_url elastic/elastic-agent-libs#154

Closed

5 tasks

sakurai-youhei added a commit to sakurai-youhei/elastic-agent-libs that referenced this pull request Oct 2, 2023

Add code for elastic/beats#36715

f8bc962

sakurai-youhei added libbeat backport-skip Skip notification from the automated backport with mergify labels Oct 2, 2023

sakurai-youhei added 3 commits October 24, 2023 22:48

Make the fix independent from another

3b0a52e

Merge branch 'elastic:main' into honor-elasticsearch-proxy_url

c649db4

Add a changelog entry

577a9ce

sakurai-youhei marked this pull request as ready for review October 24, 2023 15:55

sakurai-youhei requested a review from a team as a code owner October 24, 2023 15:55

sakurai-youhei requested review from belimawr and rdner October 24, 2023 15:55

pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Oct 25, 2023

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 25, 2023

rdner approved these changes Oct 25, 2023

View reviewed changes

belimawr reviewed Oct 27, 2023

View reviewed changes

sakurai-youhei and others added 6 commits October 28, 2023 17:27

Update libbeat/esleg/eslegclient/connection.go

6e5bc24

Co-authored-by: Tiago Queiroz <[email protected]>

Update libbeat/esleg/eslegclient/connection.go

a085274

Co-authored-by: Tiago Queiroz <[email protected]>

Shorten the receiver name

a841f3d

Tidy up Test function to be a little more readable

c5ab124

Fix an integration test failure

1740c28

Add an integration test for HTTPS Proxy

1c98d82

Merge branch 'main' into honor-elasticsearch-proxy_url

65b166a

Merge branch 'main' into honor-elasticsearch-proxy_url

39efe59

Merge branch 'main' into honor-elasticsearch-proxy_url

e6e0e53

Merge branch 'main' into honor-elasticsearch-proxy_url

9f5dfcb

Merge branch 'main' into honor-elasticsearch-proxy_url

bc8b67f

sakurai-youhei closed this Oct 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make test output honor output.elasticsearch.proxy_url #36715

Make test output honor output.elasticsearch.proxy_url #36715

sakurai-youhei commented Oct 2, 2023 •

edited

Loading

mergify bot commented Oct 2, 2023

elasticmachine commented Oct 2, 2023 •

edited by jenkins-beats-ci bot

Loading

Build stats

Test stats 🧪

sakurai-youhei commented Oct 4, 2023 •

edited

Loading

belimawr Oct 27, 2023

sakurai-youhei Oct 29, 2023

mergify bot commented Nov 1, 2023

mergify bot commented Nov 30, 2023

elasticmachine commented Dec 5, 2023

Build stats

Test stats 🧪

`Build&Test / filebeat-pythonIntegTest / test_shutdown – filebeat.tests.system.test_shutdown.Test`

`filebeat-pythonIntegTest - mage pythonIntegTest`

`filebeat-pythonIntegTest - mage pythonIntegTest`

`filebeat-pythonIntegTest - mage pythonIntegTest`

`Error signal`

Genuine test errors

mergify bot commented Dec 7, 2023

elasticmachine commented Dec 8, 2023

Build stats

Test stats 🧪

mergify bot commented Dec 12, 2023

elasticmachine commented Dec 17, 2023

Build stats

Test stats 🧪

sakurai-youhei commented Oct 22, 2024

Make test output honor output.elasticsearch.proxy_url #36715

Make test output honor output.elasticsearch.proxy_url #36715

Conversation

sakurai-youhei commented Oct 2, 2023 • edited Loading

Proposed commit message

Checklist

How to test this PR locally

Related issues

Use cases

mergify bot commented Oct 2, 2023

elasticmachine commented Oct 2, 2023 • edited by jenkins-beats-ci bot Loading

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

sakurai-youhei commented Oct 4, 2023 • edited Loading

belimawr Oct 27, 2023

Choose a reason for hiding this comment

sakurai-youhei Oct 29, 2023

Choose a reason for hiding this comment

mergify bot commented Nov 1, 2023

mergify bot commented Nov 30, 2023

elasticmachine commented Dec 5, 2023

💔 Tests Failed

Build stats

Test stats 🧪

Test errors

Build&Test / filebeat-pythonIntegTest / test_shutdown – filebeat.tests.system.test_shutdown.Test

Steps errors

filebeat-pythonIntegTest - mage pythonIntegTest

filebeat-pythonIntegTest - mage pythonIntegTest

filebeat-pythonIntegTest - mage pythonIntegTest

Error signal

🐛 Flaky test report

Genuine test errors

🤖 GitHub comments

mergify bot commented Dec 7, 2023

elasticmachine commented Dec 8, 2023

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

mergify bot commented Dec 12, 2023

elasticmachine commented Dec 17, 2023

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

sakurai-youhei commented Oct 22, 2024

sakurai-youhei commented Oct 2, 2023 •

edited

Loading

elasticmachine commented Oct 2, 2023 •

edited by jenkins-beats-ci bot

Loading

sakurai-youhei commented Oct 4, 2023 •

edited

Loading

`Build&Test / filebeat-pythonIntegTest / test_shutdown – filebeat.tests.system.test_shutdown.Test`

`filebeat-pythonIntegTest - mage pythonIntegTest`

`filebeat-pythonIntegTest - mage pythonIntegTest`

`filebeat-pythonIntegTest - mage pythonIntegTest`

`Error signal`