-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17](backport #36000) upgrade Go to 1.20.6 #36869
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upgrade Go to 1.20.5 * ignore known issue with go tool cover * capture cover output and check it for errors * debug * wip * move ragel files to root directory the //line directives used to point to the original "ragel" files were creating problems for the coverage tool. They were being reported without the 'parser/' directory. Causing the go tool cover to look for the wrong files and therefore failing. Moving it all to the root directory fixes the problem. * upgrade to go1.20.6 * . * Revert "move ragel files to root directory" This reverts commit 2b6a159. * remove debug * disable //line directives * goimport (cherry picked from commit a278734) # Conflicts: # .go-version # .golangci.yml # Vagrantfile # auditbeat/Dockerfile # dev-tools/kubernetes/filebeat/Dockerfile.debug # dev-tools/kubernetes/heartbeat/Dockerfile.debug # dev-tools/kubernetes/metricbeat/Dockerfile.debug # dev-tools/mage/gotest.go # filebeat/input/syslog/rfc5424_parser.go # heartbeat/Dockerfile # libbeat/docs/version.asciidoc # libbeat/reader/syslog/rfc3164_test.go # libbeat/reader/syslog/rfc5424_test.go # metricbeat/Dockerfile # metricbeat/module/http/_meta/Dockerfile # metricbeat/module/nats/_meta/Dockerfile # packetbeat/Dockerfile # x-pack/functionbeat/Dockerfile # x-pack/metricbeat/module/stan/_meta/Dockerfile
mergify
bot
added
backport
conflicts
There is a conflict in the backported pull request
labels
Oct 16, 2023
mergify
bot
requested review from
rdner and
fearful-symmetry
and removed request for
a team
October 16, 2023 21:11
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Oct 16, 2023
Collaborator
cmacknz
reviewed
Oct 17, 2023
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Oct 17, 2023
This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
conflicts
There is a conflict in the backported pull request
Team:Elastic-Agent
Label for the Agent team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #36000 done by Mergify.
Cherry-pick of a278734 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com