Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverless user messages #36944

Merged

Conversation

fearful-symmetry
Copy link
Contributor

Proposed commit message

Closes #36732

This adds an extra bit of logic so the setup verification method reports instructions specific to either ILM or DSL setup.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@fearful-symmetry fearful-symmetry added Team:Elastic-Agent Label for the Agent team backport-v8.11.0 Automated backport with mergify labels Oct 23, 2023
@fearful-symmetry fearful-symmetry self-assigned this Oct 23, 2023
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner October 23, 2023 17:03
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 23, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-23T17:03:21.485+0000

  • Duration: 83 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 28482
Skipped 2013
Total 30495

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@fearful-symmetry fearful-symmetry merged commit c143fa6 into elastic:main Oct 23, 2023
86 checks passed
mergify bot pushed a commit that referenced this pull request Oct 23, 2023
* separate out validation messages in index setup

* add extra line

(cherry picked from commit c143fa6)
fearful-symmetry added a commit that referenced this pull request Oct 24, 2023
* separate out validation messages in index setup

* add extra line

(cherry picked from commit c143fa6)

Co-authored-by: Alex K <[email protected]>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
* separate out validation messages in index setup

* add extra line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.11.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index management errors messages should always specify the correct index management type to use
3 participants