Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kibana] pass unique service.address value #37178

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

klacabane
Copy link
Contributor

@klacabane klacabane commented Nov 22, 2023

Summary

This change ensures all kibana metricsets set a unique service.address value. This is necessary for TSDB migration as we want to use this field as a dimension

How to test this PR locally

  • ingest kibana data
metricbeat.modules:
  - module: kibana
    xpack.enabled: true
    period: 10s
    hosts: ["http://localhost:5601"]
    username: "elastic"
    password: "changeme"
  • verify kibana metricsets publish the same unique value for service.address

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 22, 2023
Copy link
Contributor

mergify bot commented Nov 22, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @klacabane? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 52 min 16 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@klacabane klacabane added release-note:skip The PR should be ignored when processing the changelog Team:Infra Monitoring UI - DEPRECATED Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring Module:kibana Kibana Beats modules v8.12.0 labels Nov 24, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 24, 2023
@klacabane klacabane marked this pull request as ready for review November 24, 2023 09:15
@klacabane klacabane requested a review from a team as a code owner November 24, 2023 09:15
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 51 min 34 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems similar to #36582

@klacabane klacabane merged commit a1627fc into elastic:main Nov 24, 2023
26 checks passed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
* unique service.address

* fix stats metricset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module:kibana Kibana Beats modules release-note:skip The PR should be ignored when processing the changelog Team:Infra Monitoring UI - DEPRECATED Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[kibana] only allow single value in service.address
3 participants