-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-pack/filebeat/input/salesforce: Implement a new Salesforce input #37331
Conversation
- Update cursor to support custom fields from config - Update cursor implementation
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
@tommyers-elastic / @lalit-satapathy We have addressed all your review comments, we plan to merge this so we can implement the module changes. Please review and let us know if we can merge. It's okay to review the full code later; we can address any missed items (if any) in module PR. For now, we can merge the code for input. Let us know what we should do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for early release and future updates as needed.
Pinging @elastic/elastic-agent-data-plane / @elastic/ingest-eng-prod for their approval. We have made changes to the filebeat's docs and some common files and that's why your approval is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CODEOWNERS changes looks good
/test |
This reverts commit 6aaeaa8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that because the codeowners change was made after the PR was created, it is still requiring an approval from the data plane. As everybody else already approved this PR, I'm approving it without a review to unblock it.
…lastic#37331) --------- Co-authored-by: subham sarkar <[email protected]> Co-authored-by: Aman <[email protected]> Co-authored-by: Pierre HILBERT <[email protected]>
Description
Introducing a new filebeat input -- Salesforce. The existing input used for the Salesforce module was not a good choice and it didn't give us the flexibility to address some issues we were facing with HTTPJSON.
New Salesforce input is introduced to have greater control over authentication, how data is fetched and processed, and more. There are several clients available for Salesforce written in Go that execute SOQL queries against the Salesforce server and do the other needful steps (e.g., fetching EventLogFile) which were previously done in HTTPJSON. Please note that this will be completely independent of HTTPJSON input and hence there would be no relation.
Please read the technical doc to read more about the decisions taken here.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to Run this Input
Configuration
Following is the sample configuration for salesforce input:
Type: Identifies the input type as salesforce.
Enabled: Indicates whether the Salesforce input is active. Example: true
Version: Specifies the version of the Salesforce API to be used for the input. Example: 56
Auth/OAuth2 Configuration:
User Password Flow:
JWT Bearer Flow:
URL: Specifies the base URL of the Salesforce instance. Example: https://devabcdin-org-ed.develop.my.salesforce.com
Event Monitoring Method:
Event Log File:
Object:
Related issues