-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move (re-license) tracing package and introduce 'allowundefined' in kprobe struct tag #37602
Move (re-license) tracing package and introduce 'allowundefined' in kprobe struct tag #37602
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures> Show only the first 10 test failures
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relicensing of this module from x-pack's Elastic License to Apache-2.0 LGTM, on behalf of the @elastic/open-source-wg (via Slack)
License changes look good to me as well! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for well organized commits. It's much appreciated as a reviewer.
db15295
to
ced2232
Compare
💔 Build Failed
Expand to view the summary
Build stats
Pipeline error
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
thx for the review @andrewkroh 🚀 |
💔 Build Failed
Expand to view the summary
Build stats
Pipeline error
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
@efd6 did I break the packaging Jenkins steps or is this a fluke?
|
I see similar failures on main for metricbeat. https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fpackaging/detail/main/3610/pipeline/129 |
The packaging failure in tracked in #37726. |
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
@andrewkroh @efd6 is this PR clear to get merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after nits.
❕ Build Aborted
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
|
…ativeEndian" This reverts commit 19d9c28.
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
|
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
…probe struct tag (elastic#37602) * fix: replace deprecated io/ioutil with os * fix: rename local vars so they don't collide with built-in functions * feat: introduce support for allowundefined tag * fix: remove unnecessary named return variable * feat: expose the option to set the wakeup_events for the perf channel * feat: move tracing from x-pack/auditbeat to auditbeat * legal: re-license tracing from Elastic License to Apache License Version 2.0 * fix: remove deprecated ioutil in events_test.go * fix: replace naked return(s) * fix: pre-allocate slices wherever the len is known * fix: use errors.Is to check for a specific error * fix: remove unused withTime struct field from PerfChannel * fix: properly use make(chan struct{}) * fix: use raw string with regexp.MustCompile * fix: replace missed naked return(s) * fix: replace pre-allocating len of the slices with cap * feat: modernise tracing endian.go to use binary.NativeEndian * feat: refactor copyInt and readInt to use unsafe.Slice * fix: revert pollAll in perfevent.go to named returns as these can be properly documented * fix: remove redundant endian.go and utilise directly binary.NativeEndian * fix: return explicitly the named returns in pollAll * Revert "fix: remove redundant endian.go and utilise directly binary.NativeEndian" This reverts commit 19d9c28.
Proposed commit message
This PR does the following changes required to accommodate of an alternative kprobe-based BE for the File Integrity Module being developed (initial effort to support this ticket):
x-pack/auditbeat
toauditbeat
package where the above new BE for FIM will be.allowundefined
inkprobe struct tag
to be able to support allocating struct from probe perf events that not all "tagged" fields are found in the probe format.ioutil
calls with respectiveos
ones.Checklist
Author's Checklist
How to test this PR locally
Existing unit-tests of tracing package are not affected
Related issues