Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.21.6 #37694

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Update to Go 1.21.6 #37694

merged 4 commits into from
Jan 24, 2024

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Jan 22, 2024

Upgrades to Go 1.21.6. Removes support for Windows 8.1 as Go 1.21 requires Windows 10 or later as noted in the Go 1.21. release notes.

@cmacknz cmacknz added the Team:Elastic-Agent Label for the Agent team label Jan 22, 2024
@cmacknz cmacknz self-assigned this Jan 22, 2024
@cmacknz cmacknz requested review from a team as code owners January 22, 2024 17:02
@cmacknz cmacknz requested review from belimawr and rdner and removed request for a team January 22, 2024 17:02
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 22, 2024
@elasticmachine
Copy link
Collaborator

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2024-01-22T17:02:33.441+0000

  • Duration: 5 min 10 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 73 min 53 sec

Pipeline error 1

This error is likely related to the pipeline itself. Click here
and then you will see the error (either incorrect syntax or an invalid configuration).

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cmacknz
Copy link
Member Author

cmacknz commented Jan 22, 2024

/test

@elasticmachine
Copy link
Collaborator

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-01-22T20:38:28.334+0000

  • Duration: 31 min 59 sec

Test stats 🧪

Test Results
Failed 1
Passed 2355
Skipped 22
Total 2378

Test errors 1

Expand to view the tests failures

TestNewClient – github.com/elastic/beats/v7/libbeat/common/docker
    Expand to view the error details

     Failed 
    

    Expand to view the stacktrace

     === RUN   TestNewClient
        client_test.go:48: Using default API version: 1.40
        client_test.go:62: 
            	Error Trace:	/go/src/github.com/elastic/beats/libbeat/common/docker/client_test.go:62
            	Error:      	Received unexpected error:
            	            	Error response from daemon: client version 1.22 is too old. Minimum supported API version is 1.24, please upgrade your client to a newer version
            	Test:       	TestNewClient
    --- FAIL: TestNewClient (0.01s)
     
    

Steps errors 4

Expand to view the steps failures

libbeat-goIntegTest - mage goIntegTest
  • Took 11 min 3 sec . View more details here
  • Description: mage goIntegTest
libbeat-goIntegTest - mage goIntegTest
  • Took 4 min 36 sec . View more details here
  • Description: mage goIntegTest
libbeat-goIntegTest - mage goIntegTest
  • Took 4 min 49 sec . View more details here
  • Description: mage goIntegTest
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'hudson.AbortException: script returned exit code 1'

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors 1

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

  • Name: TestNewClient – github.com/elastic/beats/v7/libbeat/common/docker

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cmacknz
Copy link
Member Author

cmacknz commented Jan 22, 2024

Failing with:

[2024-01-22T21:07:54.993Z] === FAIL: libbeat/common/docker TestNewClient (0.01s)
[2024-01-22T21:07:54.993Z]     client_test.go:48: Using default API version: 1.40
[2024-01-22T21:07:54.993Z]     client_test.go:62: 
[2024-01-22T21:07:54.993Z]         	Error Trace:	/go/src/github.com/elastic/beats/libbeat/common/docker/client_test.go:62
[2024-01-22T21:07:54.993Z]         	Error:      	Received unexpected error:
[2024-01-22T21:07:54.993Z]         	            	Error response from daemon: client version 1.22 is too old. Minimum supported API version is 1.24, please upgrade your client to a newer version
[2024-01-22T21:07:54.993Z]         	Test:       	TestNewClient

Copy link
Contributor

mergify bot commented Jan 23, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update-to-go-1.21 upstream/update-to-go-1.21
git merge upstream/7.17
git push upstream update-to-go-1.21

@elasticmachine
Copy link
Collaborator

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 98 min 31 sec

Pipeline error 1

This error is likely related to the pipeline itself. Click here
and then you will see the error (either incorrect syntax or an invalid configuration).

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cmacknz
Copy link
Member Author

cmacknz commented Jan 24, 2024

Merging this, the fix for the packaging failures is #37727 which currently uses Go 1.21 features.

Edit: going to wait first, this may change.

@cmacknz cmacknz merged commit c298cea into elastic:7.17 Jan 24, 2024
99 of 113 checks passed
@cmacknz cmacknz deleted the update-to-go-1.21 branch January 24, 2024 18:11
cmacknz added a commit to cmacknz/beats that referenced this pull request Feb 1, 2024
cmacknz added a commit that referenced this pull request Feb 1, 2024
* Revert "Update to Go 1.21.6 (#37694)"

This reverts commit c298cea.

* Replaces slices.Contains with helper function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants