Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Update module name to v8 #37921

Closed
wants to merge 1 commit into from
Closed

Conversation

mengzhuo
Copy link

@mengzhuo mengzhuo commented Feb 8, 2024

Proposed commit message

The go module require version that matches release version
beats used to updated version in this issue
#15853
But forget to update to v8

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

@mengzhuo mengzhuo requested a review from a team as a code owner February 8, 2024 07:42
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 8, 2024
@mengzhuo
Copy link
Author

mengzhuo commented Feb 8, 2024

@pierrehilbert Hi, Please take a look as replacement of #37920

Copy link
Contributor

mergify bot commented Feb 8, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @mengzhuo? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 8, 2024

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-02-08T07:56:21.757+0000

  • Duration: 6 min 26 sec

Steps errors 1

Expand to view the steps failures

Shell Script
  • Took 0 min 9 sec . View more details here
  • Description: HOME=/var/lib/jenkins/workspace/Beats_beats_PR-37921 GO_VERSION=1.21.6 ./dev-tools/run_with_go_ver make test-mage

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert
Copy link
Collaborator

/test

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Feb 8, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 8, 2024
@mengzhuo
Copy link
Author

mengzhuo commented Feb 8, 2024

@pierrehilbert I dig into checks and searching for "v7" in source. It appears lots of module requires v7 but v8 can't be install by go install github.com/elastic/beats/[email protected]

Is github workflow change v7 to v8 by fly?

@cmacknz
Copy link
Member

cmacknz commented Feb 12, 2024

Leaving this at v7 was discussed some time ago, and is an intentional decision even though changing to v8 is more correct according to Go conventions.

If we change to the v8 suffix, it forces every import of Beats everywhere to be rewritten. This is a significant amount of toil across many repositories and files for very little benefit.

For now we are going to leave it at v7.

@cmacknz cmacknz closed this Feb 12, 2024
@cmacknz
Copy link
Member

cmacknz commented Feb 12, 2024

@pierrehilbert I dig into checks and searching for "v7" in source. It appears lots of module requires v7 but v8 can't be install by go install github.com/elastic/beats/[email protected]

go get github.com/elastic/beats@main should do what you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants