-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Update module name to v8 #37921
Conversation
@pierrehilbert Hi, Please take a look as replacement of #37920 |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
|
/test |
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
@pierrehilbert I dig into checks and searching for "v7" in source. It appears lots of module requires v7 but v8 can't be install by Is github workflow change v7 to v8 by fly? |
Leaving this at v7 was discussed some time ago, and is an intentional decision even though changing to v8 is more correct according to Go conventions. If we change to the v8 suffix, it forces every import of Beats everywhere to be rewritten. This is a significant amount of toil across many repositories and files for very little benefit. For now we are going to leave it at v7. |
|
Proposed commit message
The go module require version that matches release version
beats used to updated version in this issue
#15853
But forget to update to v8
Checklist