-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auditbeat TestExeObjParser - fix errors.Is argument order #38606
Conversation
The arguments to errors.Is are in the wrong order so the check is not working as designed and test is never skipped. Also stop the test after exeObjParser.Parse fails. Relates: elastic#38211
This pull request doesn't have a |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…38630) The arguments to errors.Is are in the wrong order so the check is not working as designed and test is never skipped. Also stop the test after exeObjParser.Parse fails. Relates: #38211 (cherry picked from commit cd89cc4) Co-authored-by: Andrew Kroh <[email protected]>
Proposed commit message
The arguments to
errors.Is
are in the wrong order so the check is not working as designed and the test was never skipped.Also stop the test after
exeObjParser.Parse
fails.Relates: #38211
How to test this PR locally