-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auditbeat] Remove temporary "ReplaceFields" config option #39134
[Auditbeat] Remove temporary "ReplaceFields" config option #39134
Conversation
The ReplaceFields config option was used to support compatibility with session viewer in Kibana that didn't support auditbeat fields. Kibana has now been updated, and this config option isn't needed.
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The ReplaceFields config option was used to support compatibility with session viewer in Kibana that didn't support auditbeat fields. Kibana has now been updated, and this config option isn't needed. (cherry picked from commit b34334f)
…) (#39168) The ReplaceFields config option was used to support compatibility with session viewer in Kibana that didn't support auditbeat fields. Kibana has now been updated, and this config option isn't needed. (cherry picked from commit b34334f) Co-authored-by: Michael Wolf <[email protected]>
Proposed commit message
Remove the "ReplaceFields" config option from the 'add_session_metadata' processor in Auditbeat. This was always intended to be a temporary config option, that allowed use of the Kibana session viewer, before the Kibana feature was fully developed.
The Kibana changes are now done, so this processor option is no longer needed.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inThis was developer only option, on a feature that's not GA, so I don't think it needs a changelog entryCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues