-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-pack/filebeat/input/entityanalytics/provider/okta: add user group membership support #39815
Conversation
…d user group membership support
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Worth resolving the linting errors here or do you think it's mostly noise ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🐎
So the implication of adding group enrichment with their API design is that we need to make an additional API call for each user, right?
That's correct. I did consider adding a config flag for that, but figured that it would be almost always wanted. If you think we should make this configurable, I'm happy to add that. |
The linter noise is noise. |
I don't think it's necessary. I'd rather wait and add address this if it becomes a problem. |
@efd6 I just thought of one more thing this needs, and that is to mention that the input interacts with the groups API in https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-entity-analytics.html#_api_interactions_2. |
That documentation is still strictly correct. We are going through /api/v1/users.
|
Perfect. 😆 |
Proposed commit message
See title.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
To test the internal package, you will need to obtain an okta account and then run the following in that package's directory:
Replacing the redacted parts with the appropriate values.
This should result in output similar to the following. In particular, the output for Test/none/my_groups.
Related issues
Use cases
Screenshots
Logs