Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Update version to 7.17.23 #39849

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Conversation

elasticmachine
Copy link
Collaborator

Updates references to the new release 7.17.23.

Merge after the release 7.17.22.

@elasticmachine elasticmachine requested a review from a team as a code owner June 10, 2024 16:37
@elasticmachine elasticmachine added release Team:Automation Label for the Observability productivity team labels Jun 10, 2024
@elasticmachine elasticmachine requested review from fearful-symmetry and faec and removed request for a team June 10, 2024 16:37
@elasticmachine elasticmachine self-assigned this Jun 10, 2024
@elasticmachine elasticmachine requested a review from a team June 10, 2024 16:37
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 10, 2024
@cmacknz
Copy link
Member

cmacknz commented Jun 17, 2024

It appears we are not passing the -v argument to mage in CI. Running the same tests locally:

❯ MODULE=kubernetes mage goIntegTest
Generated fields.yml for metricbeat to /Users/cmackenzie/go/src/github.com/elastic/beats/metricbeat/fields.yml
Generated fields.yml for metricbeat to /Users/cmackenzie/go/src/github.com/elastic/beats/metricbeat/fields.yml
Error: failed modules: kubernetes

With the -v flag:

❯ MODULE=kubernetes mage -v goIntegTest
Running target: GoIntegTest
Running dependency: Fields
Running dependency: moduleFieldsGo
Running dependency: libbeatAndMetricbeatCommonFieldsGo
exec: go "list" "-m"
Found Elastic Beats dir at /Users/cmackenzie/go/src/github.com/elastic/beats
exec: go "run" "/Users/cmackenzie/go/src/github.com/elastic/beats/dev-tools/cmd/module_fields/module_fields.go" "-beat" "metricbeat" "-license" "ASL2" "/Users/cmackenzie/go/src/github.com/elastic/beats/metricbeat/module"
exec: go "run" "-mod=readonly" "/Users/cmackenzie/go/src/github.com/elastic/beats/libbeat/scripts/cmd/global_fields/main.go" "-es_beats_path" "/Users/cmackenzie/go/src/github.com/elastic/beats" "-beat_path" "/Users/cmackenzie/go/src/github.com/elastic/beats/metricbeat" "-out" "fields.yml"
Generated fields.yml for metricbeat to /Users/cmackenzie/go/src/github.com/elastic/beats/metricbeat/fields.yml
exec: go "run" "-mod=readonly" "/Users/cmackenzie/go/src/github.com/elastic/beats/dev-tools/cmd/asset/asset.go" "-pkg" "include" "-in" "fields.yml" "-out" "include/fields/fields.go" "-license" "ASL2" "metricbeat"
Running dependency: fieldsYML
exec: go "run" "-mod=readonly" "/Users/cmackenzie/go/src/github.com/elastic/beats/libbeat/scripts/cmd/global_fields/main.go" "-es_beats_path" "/Users/cmackenzie/go/src/github.com/elastic/beats" "-beat_path" "/Users/cmackenzie/go/src/github.com/elastic/beats/metricbeat" "-out" "fields.yml" "module"
Generated fields.yml for metricbeat to /Users/cmackenzie/go/src/github.com/elastic/beats/metricbeat/fields.yml
Running dependency: Dashboards
Setup mage...
Running dependency: github.com/elastic/beats/v7/dev-tools/mage.buildMage
exec: mage "-f" "-goos=linux" "-goarch=arm64" "-compile" "build/mage-linux-arm64"
Setup kind...
exec: git "rev-parse" "HEAD"
Kubeconfig:  /Users/cmackenzie/go/src/github.com/elastic/beats/metricbeat/build/kind/metricbeat-7-17-23-1fdbc555f2-snapshot/kubecfg
exec: kind "create" "cluster" "--name" "metricbeat-7-17-23-1fdbc555f2-snapshot" "--kubeconfig" "/Users/cmackenzie/go/src/github.com/elastic/beats/metricbeat/build/kind/metricbeat-7-17-23-1fdbc555f2-snapshot/kubecfg" "--wait" "300s"
Creating cluster "metricbeat-7-17-23-1fdbc555f2-snapshot" ...
 ✓ Ensuring node image (kindest/node:v1.27.3) 🖼
 ✓ Preparing nodes 📦
 ✓ Writing configuration 📜
 ✓ Starting control-plane 🕹️ 
 ✓ Installing CNI 🔌
 ✓ Installing StorageClass 💾
 ✓ Waiting ≤ 5m0s for control-plane = Ready ⏳
 • Ready after 13s 💚
Set kubectl context to "kind-metricbeat-7-17-23-1fdbc555f2-snapshot"
You can now use your cluster with:

kubectl cluster-info --context kind-metricbeat-7-17-23-1fdbc555f2-snapshot --kubeconfig /Users/cmackenzie/go/src/github.com/elastic/beats/metricbeat/build/kind/metricbeat-7-17-23-1fdbc555f2-snapshot/kubecfg

Not sure what to do next? 😅  Check out https://kind.sigs.k8s.io/docs/user/quick-start/
>> Running testing inside of kubernetes...
>> Applying module manifest to cluster...
exec: kubectl "apply" "-f" "/Users/cmackenzie/go/src/github.com/elastic/beats/metricbeat/module/kubernetes/kubernetes.yml"
clusterrole.rbac.authorization.k8s.io/kube-state-metrics created
clusterrolebinding.rbac.authorization.k8s.io/kube-state-metrics created
serviceaccount/kube-state-metrics created
deployment.apps/kube-state-metrics created
service/kube-state-metrics created
statefulset.apps/basic-sts created
resourcequota/object-counts created
error: resource mapping not found for name: "basic-cronjob" namespace: "" from "/Users/cmackenzie/go/src/github.com/elastic/beats/metricbeat/module/kubernetes/kubernetes.yml": no matches for kind "CronJob" in version "batch/v1beta1"
ensure CRDs are installed first
>> Done running testing inside of kubernetes...
Teardown kind...
exec: kind "delete" "cluster" "--name" "metricbeat-7-17-23-1fdbc555f2-snapshot"
Deleting cluster "metricbeat-7-17-23-1fdbc555f2-snapshot" ...
Deleted nodes: ["metricbeat-7-17-23-1fdbc555f2-snapshot-control-plane"]
Teardown mage...
Error: failed modules: kubernetes

The actual error is /Users/cmackenzie/go/src/github.com/elastic/beats/metricbeat/module/kubernetes/kubernetes.yml": no matches for kind "CronJob" in version "batch/v1beta1

This error is not caused by the version bump.

@cmacknz
Copy link
Member

cmacknz commented Jun 17, 2024

We need to switch the apiVersion used in the kuberentes.yml to fix the build, as was done in 644d026. The k8s version used in the tests must have been updated. I will open a PR.

@pierrehilbert
Copy link
Collaborator

Thx Craig for your investigation and catching this!

@pierrehilbert pierrehilbert merged commit 145c035 into 7.17 Jun 17, 2024
101 of 105 checks passed
@pierrehilbert pierrehilbert deleted the update-version-next-7.17.23 branch June 17, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants