-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable TestGroup_Go and fix flaky behavior #41230
Conversation
910ecd2
to
63a1d3a
Compare
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
@mauri870 did you run this test with the race detector enabled? Looking at the improvements you did, it looks like the older version of the test should have been flagged by it 🤔 |
You are right, perhaps it was not a race condition per-se. I noticed that sometimes the contents of the log would not include log messages from both goroutines, even when both had finished executing already. I think the changes to the logger are still welcome tho, it is now safe to use in multiple goroutines without syncronization. |
(cherry picked from commit 66dacd9)
(cherry picked from commit 66dacd9) Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Proposed commit message
This PR re-enables the TestGroup_Go test, which was skipped in #41223. It also includes fixes to mitigate flakiness in the test logger caused by timming issues and ensures proper waiting for success conditions within the tests.
How to test this PR locally
Related issues