system-logs input ignores folders and add tests #41296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belimawr
added
Team:Elastic-Agent-Data-Plane
botelastic
bot
added
needs_team
|
|
mergify
bot
added
the
backport-8.x
belimawr
changed the title
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
pierrehilbert
requested review from
mauri870
and removed request for
khushijain21
mauri870
reviewed
Oct 22, 2024
mauri870
approved these changes
Oct 22, 2024
system-logs input now ignores directories when checking if files matching the provided globs exist.
`os.CopyFS` is only available in Go 1.23, so use `github.com/otiai10/copy` that is already a dependency instead.
belimawr
force-pushed
the
41259-add-tests-for-system-logs
branch
from
3f28a9c
to
511d658
Compare
mergify bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
The system-logs input now does not count folders as an "existing file" when looking for files to decide between the journald and log inputs. Unit and integration tests are added for the system-logs input. (cherry picked from commit e82c43c)
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
The system-logs input now does not count folders as an "existing file" when looking for files to decide between the journald and log inputs. Unit and integration tests are added for the system-logs input. (cherry picked from commit e82c43c)
3 tasks
pierrehilbert
pushed a commit
that referenced
this pull request
Oct 23, 2024
The system-logs input now does not count folders as an "existing file" when looking for files to decide between the journald and log inputs. Unit and integration tests are added for the system-logs input. (cherry picked from commit e82c43c) Co-authored-by: Tiago Queiroz <[email protected]>
pierrehilbert
pushed a commit
that referenced
this pull request
Oct 23, 2024
The system-logs input now does not count folders as an "existing file" when looking for files to decide between the journald and log inputs. Unit and integration tests are added for the system-logs input. (cherry picked from commit e82c43c) Co-authored-by: Tiago Queiroz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note fore reviewers
This PR is not labelled as a bug, but it covers a corner case that wasn't covered before and adds tests, hence I believe it can fall into the "bugfix" category and be backported to 8.16 making it into the 8.16.0 release.
Proposed commit message
The system-logs input now does not count folders as an "existing file"
when looking for files to decide between the journald and log inputs.
Unit and integration tests are added for the system-logs input.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.## Disruptive User Impact## Author's ChecklistHow to test this PR locally
Ideally run those tests on Linux so all of them will execute
Related issues
system-logsinput #41259## Use cases## Screenshots## Logs