Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x](backport #41097) [vSphere] Add id field to all the metricsets #41359

Merged
merged 1 commit into from
Oct 28, 2024
Merged

[8.x](backport #41097) [vSphere] Add id field to all the metricsets #41359

merged 1 commit into from
Oct 28, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 22, 2024

Description

Added id field to all the metricsets.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

This is an automatic backport of pull request #41097 done by [Mergify](https://mergify.com).

@niraj-elastic @mergify
[vSphere] Add id field to all the metricsets (#41097)
c88c8a4 
* add id field

* update changelog

* fix unit test

* update field descriptions

* update fields.asci

* fix lint

* address review comments

* update fields.asci

(cherry picked from commit ec92e02)
@mergify mergify bot requested a review from a team as a code owner October 22, 2024 05:44
@mergify mergify bot added the backport label Oct 22, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 22, 2024
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Oct 28, 2024

This pull request has not been merged yet. Could you please review and merge it @niraj-elastic? 🙏

@kush-elastic kush-elastic added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Oct 28, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 28, 2024
ishleenk17
ishleenk17 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, as its an auto backport PR

@shmsr
Copy link
Member

shmsr commented Oct 28, 2024

@kush-elastic Are there any PRs (related to vsphere) pending to backport to 8.x before this? I hope the order is maintained else it'd a pain later to fix the conflicts.

@kush-elastic
Copy link
Collaborator

@kush-elastic Are there any PRs (related to vsphere) pending to backport to 8.x before this? I hope the order is maintained else it'd a pain later to fix the conflicts.

No, all the previous PRs are already backported to 8.x.

@kush-elastic kush-elastic merged commit 42c452c into 8.x Oct 28, 2024
32 checks passed
@kush-elastic kush-elastic deleted the mergify/bp/8.x/pr-41097 branch October 28, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmsr shmsr shmsr approved these changes

@ishleenk17 ishleenk17 ishleenk17 approved these changes

@harnish-elastic harnish-elastic Awaiting requested review from harnish-elastic

Assignees

@niraj-elastic niraj-elastic

Labels
backport Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shmsr @kush-elastic @ishleenk17 @niraj-elastic