Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16](backport #41356) Restore memory queue's internal event cleanup after a batch is vended #41363

Merged
merged 1 commit into from
Oct 22, 2024

Commits on Oct 22, 2024

  1. Restore memory queue's internal event cleanup after a batch is vended (

    …#41356)
    
    Fix #41355, where event data in the memory queue was not being freed when event batches were acknowledged, but only gradually as the queue buffer was overwritten by later events. This gave the same effect as if all beat instances, even low-volume ones, were running with a full / saturated event queue.
    
    The root cause, found by @swiatekm, is [this PR](#39584), an unrelated cleanup of old code that accidentally included one live call along with the deprecated ones. (There was an old `FreeEntries` hook in pipeline batches that was only used for deprecated shipper configs, but the cleanup also removed the `FreeEntries` call _inside_ the queue which was essential for releasing event memory.)
    
    (cherry picked from commit fdb912a)
    faec authored and mergify[bot] committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c52c168 View commit details
    Browse the repository at this point in the history