Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Mention run docs-build #42449

Merged
merged 6 commits into from
Feb 7, 2025
Merged

Conversation

orestisfl
Copy link
Contributor

Proposed commit message

README.md: Mention run docs-build

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@orestisfl orestisfl self-assigned this Jan 28, 2025
@orestisfl orestisfl requested a review from a team as a code owner January 28, 2025 13:54
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 28, 2025
@orestisfl orestisfl added docs and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 28, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 28, 2025
@orestisfl orestisfl added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 28, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Copy link
Contributor

mergify bot commented Jan 28, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @orestisfl? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jan 28, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 28, 2025
@orestisfl orestisfl enabled auto-merge (squash) January 28, 2025 16:48
@orestisfl orestisfl closed this Jan 29, 2025
auto-merge was automatically disabled January 29, 2025 15:26

Pull request was closed

@orestisfl orestisfl deleted the run-docs-build branch January 29, 2025 15:26
@mauri870
Copy link
Member

Did you mean to close this @orestisfl? I think the change is very welcome. I sometimes forget the actual command and have to look up older PRs to find it.

@orestisfl orestisfl restored the run-docs-build branch January 29, 2025 15:43
@orestisfl
Copy link
Contributor Author

@mauri870, you are right 🤦 I was cleaning up my fork, I thought this was merged already 😅

@orestisfl orestisfl reopened this Jan 29, 2025
@orestisfl orestisfl enabled auto-merge (squash) January 29, 2025 15:44
orestisfl and others added 4 commits January 29, 2025 16:44
@pierrehilbert pierrehilbert added the backport-9.0 Automated backport to the 9.0 branch label Feb 7, 2025
@faec
Copy link
Contributor

faec commented Feb 7, 2025

This PR seems stuck -- it says merging is blocked because Required status check "buildkite/beats" was not set by the expected GitHub app but the buildkite/beats step says it was skipped because "No changes required CI" (which makes sense since it's a doc-only change), so maybe it's a failed corner case that buildkite/beats isn't detected as passing when it's unnecessary?

(edit) cc @pierrehilbert maybe you can figure it out or force-merge if needed?

@pierrehilbert pierrehilbert merged commit fb6f868 into elastic:main Feb 7, 2025
10 checks passed
mergify bot pushed a commit that referenced this pull request Feb 7, 2025
Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Co-authored-by: Fae Charlton <[email protected]>
(cherry picked from commit fb6f868)
mergify bot pushed a commit that referenced this pull request Feb 7, 2025
Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Co-authored-by: Fae Charlton <[email protected]>
(cherry picked from commit fb6f868)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch docs Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants