[8.x](backport #42017) [Metricbeat] Windows Module add wmi metricset #42505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Add stub for wmi module * Execute mage update * Add first draft of wmi metricset * Add first draft of wmi windows module * Add config unit test * Add unit test for the config class * Add license notice mage fmt * Add License to wmi/wmi.go * Update example * Use wrapping fromat verb for fmt.Errorf * Fix mispelled comment * Add first draft of the documentation * Add the config reference and config file * Bump microsfot/wmi to 0.25.1 * Make sure the wmi metricset is only used on windows * Run mage update * Add License for microsoft/wmi library in Notice.txt * Add Timeout configuration * Introduce the ExecuteGuardedQueryInstances to wait for at most a timeout for the result * Add invokation of CloseAllInstances() to make sure to free resources after need * Add license header to utils.go * Rename timeout to warning_threshold to conceive the message that the query is not actually cancelled * Refactor the ExecuteGuardedQueryInstances to use the context.WithTimeout * Add unit test for ExecuteGuardedQueryInstances Add an interface WmiQueryInterface to allow mocking the session object * Add parameter IncludeEmptyString. Create function to check skip conditions and add a test * Add namespace at the query level and add a structure to index queries on the namespace. Add logic to create a single connection per Namespace * Rename the config method to be more explicit * Add Primitives to deal with the type convrsion for strings * Add unit test for the conversion function * Add heuristic to determine if fetching the CIMType is needed * Add type conversion * Improve comments to explicitly state what are the config parameters used for * Add license header to wmi and utils test * Run mage fmt * Update the reference config after the final implementation * Remove the dummy field definition * Add sample data in the data.json file * Fix go.mod and change NOTICE.txt to reflect the fact that go-ole is now directly used in the WMI module * Make sure that the wmi tests run only on windows * Improve the error message to prepare a Troubleshooting Guide * Fix test to use right function * Add doc.go file * Add pragma to avoid compiling utils.go on platforms other than windows * Run make update BEATS=metricbeat * Use Metricset Logger instead of generic one in wmi.go * Make sure that we are using the Metricset logger everywhere. Address linting error caused by not checking the return of rawResult.Clear() * Run make updates BEATS=metricbeat * Get rid of duplicated rawResult.Clear() * Review: remove redundant multiplication by time.Second * Review: Fix grammar of error * Review: Get rid of the panic * Review: Remove redundant check * Review: Make the namespace settings easier to understand * Review: Honor the query-level namespace in the output document and move the field type caching at the query level rather than namespace level * Add a warning if a given query is not producing results * Fix golint warning * add results of 'make update' * Add changelog entry for the wmi metricset * Fix pull request number * Add an explicit variable for the converted field and double check if the cast is safe * Make warning easier to read * Add empty newline in the config.yml * Add codeowners entry for wmi * Add windows.yml.disabled * Modify codeowners at the dataset level * Fix test after renaming of the error message * Update metricbeat/docs/modules/windows.asciidoc Co-authored-by: Liam Thompson <[email protected]> * Fix config reference to generate correct doc * Update xpack metricbeat.reference.yml --------- Co-authored-by: tommyers-elastic <[email protected]> Co-authored-by: Ishleen Kaur <[email protected]> Co-authored-by: Liam Thompson <[email protected]> (cherry picked from commit 35fbdce)
mergify
bot
requested review from
AndersonQ and
khushijain21
and removed request for
a team
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
[Metricbeat][Windows] Add experimental wmi metricset
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
This PR does not have impact to existing use-cases
Author's Checklist
How to test this PR locally
Related issues
Use cases
As a windows user I want to leverage WMI (and in particular WQL, SQL for WMI) to extract detailed system information and metrics.
Screenshots
Logs
This is an automatic backport of pull request #42017 done by [Mergify](https://mergify.com).