Skip to content

Commit

Permalink
api: Add missing Create response on traffic rule assoc (#200)
Browse files Browse the repository at this point in the history
Adds the status code of the POST traffic rule association to `201`
to match all of the endpoint API responses.

And bumps the version to `1.0.1` and `2.6.1`.

Signed-off-by: Marc Lopez <[email protected]>
  • Loading branch information
marclop authored Sep 1, 2020
1 parent cf1bd5b commit 32d7e33
Show file tree
Hide file tree
Showing 7 changed files with 416 additions and 15 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
SHELL := /bin/bash
export GO111MODULE ?= on
export VERSION ?= v1.0.0
export ECE_VERSION ?= 2.6.0
export VERSION ?= v1.0.1
export ECE_VERSION ?= 2.6.1
ECE_DEF_FILE ?= api/version/$(ECE_VERSION).md
export GOBIN = $(shell pwd)/bin
BINARY := cloud-sdk-go
Expand Down
8 changes: 7 additions & 1 deletion api/apidocs.json
Original file line number Diff line number Diff line change
Expand Up @@ -10546,12 +10546,18 @@
}
} ],
"responses" : {
"200" : {
"201" : {
"description" : "Create association request was valid and the association has been created",
"schema" : {
"$ref" : "#/definitions/EmptyResponse"
}
},
"200" : {
"description" : "Create association request was valid and the association already exists",
"schema" : {
"$ref" : "#/definitions/EmptyResponse"
}
},
"404" : {
"description" : "The traffic filter ruleset specified by {ruleset_id} cannot be found. (code: `traffic_filter.not_found`)",
"headers" : {
Expand Down
359 changes: 359 additions & 0 deletions api/version/2.6.1.md

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@ github.com/go-openapi/runtime v0.19.4 h1:csnOgcgAiuGoM/Po7PEpKDoNulCcF3FGbSnbHfx
github.com/go-openapi/runtime v0.19.4/go.mod h1:X277bwSUBxVlCYR3r7xgZZGKVvBd/29gLDlFGtJ8NL4=
github.com/go-openapi/runtime v0.19.15 h1:2GIefxs9Rx1vCDNghRtypRq+ig8KSLrjHbAYI/gCLCM=
github.com/go-openapi/runtime v0.19.15/go.mod h1:dhGWCTKRXlAfGnQG0ONViOZpjfg0m2gUt9nTQPQZuoo=
github.com/go-openapi/runtime v0.19.19 h1:PCaQSqG0HiCgpekchPrHO9AEc5ZUaAclOUp9T3RSKoQ=
github.com/go-openapi/runtime v0.19.19/go.mod h1:Lm9YGCeecBnUUkFTxPC4s1+lwrkJ0pthx8YvyjCfkgk=
github.com/go-openapi/runtime v0.19.20 h1:J/t+QIjbcoq8WJvjGxRKiFBhqUE8slS9SbmD0Oi/raQ=
github.com/go-openapi/runtime v0.19.20/go.mod h1:Lm9YGCeecBnUUkFTxPC4s1+lwrkJ0pthx8YvyjCfkgk=
github.com/go-openapi/spec v0.17.0/go.mod h1:XkF/MOi14NmjsfZ8VtAKf8pIlbZzyoTvZsdfssdxcBI=
Expand Down
2 changes: 1 addition & 1 deletion pkg/api/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ package api
// on the minor version, i.e: 2.4.2 means that all the 2.4 branch is supported,
// expecting some potentially unfixed bugs when ECE version is the same feature
// version bug higher bugfix version.
const Version = "2.6.0"
const Version = "2.6.1"

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 32d7e33

Please sign in to comment.