Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty instance_config_version in topology elements #450

Merged

Conversation

claudia-correia
Copy link
Contributor

Description

This changes the type of the instance_configuration_version field to *int32 for all topology elements and marks the fields as nullable.

Related Issues

Rel: https://elasticco.atlassian.net/browse/CP-5181

Motivation and Context

We can't set instance_configuration_version to 0 because it will be considered as an empty value and it will be omitted during JSON marshalling.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@claudia-correia claudia-correia added the bug Something isn't working label Dec 14, 2023
@claudia-correia claudia-correia requested a review from a team as a code owner December 14, 2023 12:12
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@claudia-correia claudia-correia merged commit 87ffc76 into elastic:master Dec 14, 2023
1 check passed
@claudia-correia claudia-correia deleted the update-ic-version-type branch December 14, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants