remove redundant TODOs

elastic · Mar 26, 2024 · 411cbe9 · 411cbe9
1 parent deb693f
commit 411cbe9
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/internal/flavors/benchmark/aws.go b/internal/flavors/benchmark/aws.go
@@ -67,8 +67,6 @@ func (a *AWS) initialize(ctx context.Context, log *logp.Logger, cfg *config.Conf
 	)
 
 	awsConfig, awsIdentity, err = a.getIdentity(ctx, cfg)
-	// TODO(kuba): Ask when the DefaultRegion is empty. Is there a chance it is
-	// set, but incorrectly - e.g. "us-east-1"?
 	if err != nil && cfg.CloudConfig.Aws.Cred.DefaultRegion == "" {
 		log.Warn("failed to initialize identity; retrying to check AWS Gov Cloud regions")
 		cfg.CloudConfig.Aws.Cred.DefaultRegion = awslib.DefaultGovRegion
@@ -87,7 +85,6 @@ func (a *AWS) initialize(ctx context.Context, log *logp.Logger, cfg *config.Conf
 }
 
 func (a *AWS) getIdentity(ctx context.Context, cfg *config.Config) (*awssdk.Config, *cloud.Identity, error) {
-	// TODO: make this mock-able
 	awsConfig, err := aws.InitializeAWSConfig(cfg.CloudConfig.Aws.Cred)
 	if err != nil {
 		return nil, nil, fmt.Errorf("failed to initialize AWS credentials: %w", err)

diff --git a/internal/flavors/benchmark/aws_org.go b/internal/flavors/benchmark/aws_org.go
@@ -219,7 +219,6 @@ func (a *AWSOrg) pickManagementAccountRole(ctx context.Context, log *logp.Logger
 }
 
 func (a *AWSOrg) getIdentity(ctx context.Context, cfg *config.Config) (*awssdk.Config, *cloud.Identity, error) {
-	// TODO: make this mock-able
 	awsConfig, err := aws.InitializeAWSConfig(cfg.CloudConfig.Aws.Cred)
 	if err != nil {
 		return nil, nil, fmt.Errorf("failed to initialize AWS credentials: %w", err)