Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Create Serverless QA Environment #1982

Closed
wants to merge 91 commits into from

Conversation

Omolola-Akinleye
Copy link
Contributor

@Omolola-Akinleye Omolola-Akinleye commented Feb 22, 2024

Summary of your changes

This PR creates a Serverless QA Environment. In this PR we updated Mask Sensitive Data to update the TF_VAR_ec_api_key with the secrets QA API KEY when input.ec-url is https://console.qa.cld.elstc.co.

Also, we added options

Screenshot/Data

Related Issues

elastic/kibana#176748

Copy link

github-actions bot commented Apr 1, 2024

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 359
⬜ Skipped 33

@gurevichdmitry
Copy link
Collaborator

@Omolola-Akinleye, The last workflow's successful run didn't involve destroying the environment. Can you please ensure that the destruction process is also functioning correctly?

@Omolola-Akinleye
Copy link
Contributor Author

Omolola-Akinleye commented Apr 4, 2024

@Omolola-Akinleye, The last workflow's successful run didn't involve destroying the environment. Can you please ensure that the destruction process is also functioning correctly?

@gurevichdmitry I created another workflow and also deleted the workflow.

@@ -17,6 +17,8 @@ AWS_REGION="eu-west-1" # Add your desired default AWS region here
DELETED_ENVS=()
FAILED_ENVS=()

: "${TF_VAR_qa_ec_api_key:?Please set TF_VAR_qa_ec_api_key with an Elastic QA Cloud API Key}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Omolola-Akinleye I'm unsure if this is the appropriate location to request the TF_VAR_qa_ec_api_key. Since I intend to delete a production environment, the TF_VAR_qa_ec_api_key isn't necessary. If I define it here, both keys would be required.

Copy link
Collaborator

@gurevichdmitry gurevichdmitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Omolola-Akinleye I've updated the branch and it appears that the CI is failing due to linting issues. Could you please fix them?

Copy link

mergify bot commented Jul 12, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b qa-dev-env upstream/qa-dev-env
git merge upstream/main
git push upstream qa-dev-env

@Omolola-Akinleye
Copy link
Contributor Author

Closing PR as result of QA environment being created

@oren-zohar oren-zohar deleted the qa-dev-env branch November 6, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serverless QA Environment
3 participants