-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Asset Inventory][Azure] Add missing resources and ECS fields required for GA #2954
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
As for coveralls, it fails on internal/resources/providers/msgraph/provider.go, which I tried wrapping in unit tests, but I gave up on it since the upstream SDK is auto-generated and does not lend itself to testing. |
Summary of your changes
This PR:
Role
andPrincipal
where it is impossible to test right nowOutstanding issues⚠️
The PR does not address all taxonomy issues and skips filling ECS fields for Role and Principal. A follow-up ticket will be created.
Related Issues
Closes https://github.com/elastic/security-team/issues/11690
Checklist