Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally run rebuild or incremental build #2930

Conversation

bmorelli25
Copy link
Member

Summary

In #2929, we reverted to incremental builds run every 30 minutes. This works great, until a PR is merged to the elastic/docs repository. Almost every PR merged in this repo requires a rebuild in order for the changes to take effect on elastic.co/guide/*.

This PR checks to see if the build commit of elastic/docs has changed since the previous scheduled run. If it has changed, we run a full docs rebuild. If it hasn't changed, there's no need for a full rebuild, and we instead run an incremental build.

I have no idea if this works or how to even begin testing it.

@bmorelli25 bmorelli25 requested a review from nkammah February 8, 2024 20:49
@bmorelli25 bmorelli25 self-assigned this Feb 8, 2024
@bmorelli25 bmorelli25 requested a review from a team as a code owner February 8, 2024 20:49
Copy link

github-actions bot commented Feb 8, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@bmorelli25
Copy link
Member Author

Replacing this with #2931 because I can't figure out how to test a fork and testing on upstream is easy.

@bmorelli25 bmorelli25 closed this Feb 9, 2024
@bmorelli25 bmorelli25 deleted the full-rebuild-after-elastic-docs-merge branch February 9, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants