[RFC] Stage 1 for volume device #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebeahan
reviewed
Jul 7, 2023
rfcs/text/0040-volume-device.md
Outdated
| @@ -106,6 +106,7 @@ The following are the people that consulted on the contents of this RFC. | |||
|
|
|||
| * @Trinity2019 | author | |||
| * @ricardoelastic | reviewer | |||
There was a problem hiding this comment.
Should either @ricardoelastic or @stanek-michal be added as reviewers?
There was a problem hiding this comment.
Yes. I'll ask them in slack as well
Trinity2019
commented
Jul 18, 2023
| @@ -29,13 +29,8 @@ This RFC propose adding the volume device fieldset to describe volume storage de | |||
| * volume.vendor_name | |||
| * volume.serial_number | |||
| * volume.volume_device_type | |||
| * volume.action | |||
There was a problem hiding this comment.
I removed action because I plan to use event.action for logging the information
stanek-michal
approved these changes
Jul 24, 2023
|
@ebeahan can we get this PR merged? |
ebeahan
reviewed
Jul 26, 2023
ebeahan
reviewed
Jul 26, 2023
ebeahan
approved these changes
Jul 27, 2023
| ] | ||
| }, | ||
| "message": "Endpoint volume device event", | ||
| "volume.bus_type": "FileBackedVirtual", |
There was a problem hiding this comment.
No need to fix for this round, but in a future stage let's correct the example to use an object vs. the dot notation for clarity.
Suggested change
| "volume.bus_type": "FileBackedVirtual", | |
| "volume": { | |
| "bus_type": "FileBackedVirtual", |
There was a problem hiding this comment.
Thanks @ebeahan for the suggestions:) will fix in the next round.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make test? - N/Amakeand committed those changes? - N/A