Comply with ECS for host.name
#168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonQ
added
bug
AndersonQ
requested review from
belimawr and
VihasMakwana
and removed request for
a team
AndersonQ
changed the title
host.namehost.name
AndersonQ
force-pushed
the
39993-fqdn-as-is
branch
2 times, most recently
from
f48170d
to
75d8f73
Compare
|
@AndersonQ now elastic/go-sysinfo#231 has been merged, could you please move forward and update the dependencies to use the correct one? |
on it |
VihasMakwana
approved these changes
Jul 26, 2024
|
@AndersonQ looks good now, #169 is merged |
Upgrades go-sysinfo to v1.14.1, which does not lower-case the FQDN. Therefore, `host.name` returned by `host.MapHostInfo` is lower-cased to comply with ECS.
AndersonQ
force-pushed
the
39993-fqdn-as-is
branch
from
84a493e
to
10157c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrades go-sysinfo to v1.14.1, which does not lower-case the FQDN. Therefore,
host.namereturned byhost.MapHostInfois lower-cased to comply with ECS.Why is it important?
The FQDN should not be lower-cased by default and the
host.hostname, when set to FQDN, should be the FQDN as defined in the system.Checklist
[ ] I have commented my code, particularly in hard-to-understand areasCHANGELOG.mdRelated issues
host.hostnameis being lowercased beats#39993