Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip flaky TestEnrollAndLog E2E test #3110

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Skip flaky TestEnrollAndLog E2E test #3110

merged 1 commit into from
Jul 20, 2023

Conversation

ycombinator
Copy link
Contributor

What does this PR do?

This PR skips the flaky TestEnrollAndLog E2E test.

Why is it important?

To avoid flaky tests.

Related issues

@ycombinator ycombinator added Team:Elastic-Agent Label for the Agent team flaky-test Unstable or unreliable test cases. skip-changelog Testing backport-v8.9.0 Automated backport with mergify labels Jul 20, 2023
@ycombinator ycombinator requested a review from a team as a code owner July 20, 2023 16:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

This was referenced Jul 20, 2023
Closed
Merged
pchila
pchila reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@pchila pchila left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we already have an issue to investigate and fix this ?
Nvm just saw #3081

pchila
pchila approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycombinator
Copy link
Contributor Author

/test

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 20, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-20T18:43:00.424+0000

  • Duration: 24 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 6095
Skipped 27
Total 6122

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 20, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.718% (77/78) ❕
Files 68.657% (184/268) ❕
Classes 67.606% (336/497) ❕
Methods 54.128% (1049/1938) ❕
Lines 40.228% (12000/29830) ❕
Conditionals 100.0% (0/0) 💚

@ycombinator ycombinator enabled auto-merge (squash) July 20, 2023 16:54
@ycombinator
Copy link
Contributor Author

/test

@ycombinator
Copy link
Contributor Author

This PR is now failing due to a data race detected in another test. Here's the PR to fix that data race: #3111. I made it a separate PR so that this PR here (#3110) could be easily reverted once the root cause for TestEnrollAndLog is investigated and fixed.

@ycombinator
Copy link
Contributor Author

/test

blakerouse
blakerouse approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ycombinator ycombinator merged commit a659bbb into elastic:main Jul 20, 2023
11 of 14 checks passed
mergify bot pushed a commit that referenced this pull request Jul 20, 2023
@ycombinator @mergify
Skip flaky TestEnrollAndLog (#3110)
3d4711d 
(cherry picked from commit a659bbb)
@mergify mergify bot mentioned this pull request Jul 20, 2023
Merged
ycombinator added a commit that referenced this pull request Jul 24, 2023
@mergify @ycombinator
Skip flaky TestEnrollAndLog (#3110) (#3112)
a35e978 
(cherry picked from commit a659bbb)

Co-authored-by: Shaunak Kashyap <[email protected]>
@ycombinator ycombinator deleted the disable-flaky-enroll-test branch November 27, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

@pchila pchila pchila approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@ycombinator ycombinator

Labels
backport-v8.9.0 Automated backport with mergify flaky-test Unstable or unreliable test cases. skip-changelog Team:Elastic-Agent Label for the Agent team Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ycombinator @elasticmachine @blakerouse @pchila