Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11](backport #3548) Replace timer with ticker in download progress reporter #3579

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 10, 2023

This is an automatic backport of pull request #3548 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Replace timer with ticker in download progress reporter

* Adding CHANGELOG entry

* Refactoring: extracting common code into helper function

(cherry picked from commit 1c5010f)
@mergify mergify bot requested a review from a team as a code owner October 10, 2023 19:47
@mergify mergify bot removed the request for review from a team October 10, 2023 19:47
@mergify mergify bot added the backport label Oct 10, 2023
@mergify mergify bot requested review from AndersonQ and pchila October 10, 2023 19:47
@ycombinator ycombinator enabled auto-merge (squash) October 10, 2023 19:47
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-10T19:47:21.444+0000

  • Duration: 29 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 6465
Skipped 59
Total 6524

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.78% (81/82) 👍
Files 66.667% (198/297) 👍
Classes 65.461% (362/553) 👍
Methods 52.909% (1146/2166) 👍
Lines 38.526% (13086/33967) 👍 0.068
Conditionals 100.0% (0/0) 💚

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Oct 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@ycombinator
Copy link
Contributor

buildkite test this

@mergify
Copy link
Contributor Author

mergify bot commented Oct 16, 2023

This pull request has not been merged yet. Could you please review and merge it @ycombinator? 🙏

@elastic-sonarqube
Copy link

@ycombinator ycombinator merged commit bec2b39 into 8.11 Oct 16, 2023
26 checks passed
@ycombinator ycombinator deleted the mergify/bp/8.11/pr-3548 branch October 16, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants