Improve integration testing cloud client DeploymentIsReady. #4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakerouse
added
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
rdner
approved these changes
Jun 4, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
Improves the logic in DeploymentIsReady to not return false and the error when it gets an error back from the API. Instead it will keep retrying until the timeout. (cherry picked from commit a28bc90)
2 tasks
jlind23
pushed a commit
that referenced
this pull request
Jun 5, 2024
…4841) Improves the logic in DeploymentIsReady to not return false and the error when it gets an error back from the API. Instead it will keep retrying until the timeout. (cherry picked from commit a28bc90) Co-authored-by: Blake Rouse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the logic in
DeploymentIsReadyto not returnfalseand the error when it gets an error back from the API. Instead it will keep retrying until the timeout.Why is it important?
Improve reliability of integration tests, when the cloud API returns an HTTP error or disconnects without a response (just the nature of HTTP protocol).
Checklist
Related issues