Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure container docker image #493

Closed
wants to merge 1 commit into from
Closed

Conversation

narph
Copy link
Contributor

@narph narph commented Jun 1, 2022

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@mergify mergify bot assigned narph Jun 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2022

This pull request does not have a backport label. Could you fix it @narph? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Jun 1, 2022
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-01T09:30:25.665+0000

  • Duration: 36 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 5973
Skipped 23
Total 5996

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 97.183% (69/71) 👍
Files 68.182% (150/220) 👍
Classes 67.955% (299/440) 👍
Methods 51.668% (821/1589) 👍
Lines 38.054% (8803/23133) 👎 -0.056
Conditionals 100.0% (0/0) 💚

@@ -170,8 +176,6 @@ RUN readlink -f {{ $beatBinary }} | xargs setcap {{ .linux_capabilities }}
RUN mkdir /app
{{- end }}
{{- else }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to remove all this conditional logic depending on the user of the image, and remove the parts run only for user root.
This comes from the template used by Beats, where there were beats images run with user root (auditbeat and packetbeat IIRC). But all elastic-agent images use the elastic-agent user, find the definition here.
This would simplify this template.

@@ -242,6 +246,6 @@ CMD ["/app/apm.sh"]
RUN echo -e '#!/bin/sh\nexec /usr/local/bin/docker-entrypoint' > /app/apm.sh && \
chmod 0555 /app/apm.sh
{{- else }}
ENTRYPOINT ["/usr/bin/tini", "--", "/usr/local/bin/docker-entrypoint"]
ENTRYPOINT ["/usr/bin/tini", "-s", "--", "/usr/local/bin/docker-entrypoint"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change anything when tini is executed as PID 1?

Notice that this breaks compatibility with Linux < 3.4. But I guess we don't support any distribution with such old versions, so I guess this is fine.

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b azure-container upstream/azure-container
git merge upstream/main
git push upstream azure-container

2 similar comments
@mergify
Copy link
Contributor

mergify bot commented Sep 26, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b azure-container upstream/azure-container
git merge upstream/main
git push upstream azure-container

@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b azure-container upstream/azure-container
git merge upstream/main
git push upstream azure-container

@jlind23 jlind23 closed this Mar 20, 2023
@michalpristas michalpristas mentioned this pull request Jul 14, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants