-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write container-paths.yml
into the STATE_PATH
#4995
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
@blakerouse Looking at the How to test this PR locally section of this PR, I see that we'd need to run Agent in a read-only container like so:
Just want to confirm that, even with the changes in this PR, the cc: @kilfoyle |
Moved back to draft, as I adjust this to write the |
container-paths.yml
container-paths.yml
into the STATE_PATH
I have updated this PR to write the |
Quality Gate failedFailed conditions |
SonarQube, as usual, isn't able to account for coverage from integration tests so that check is falsely failing. Other checks are passing, so force merging. |
* Don't write container paths. * Clean up. * Add changelog. * Store container-paths.yml in STATE_PATH. * Update 1719266012-Don't-fail-when-unable-to-write-container-paths.yaml * fix issue with empty value * Fix test. (cherry picked from commit c46a379) # Conflicts: # testing/integration/container_cmd_test.go
What does this PR do?
Adjusts the
container
subcommand to write thecontainer-paths.yml
into theSTATE_PATH
on startup.Why is it important?
When running the Elastic Agent container with
--read-only
it is not possible for the container to write thecontainer-paths.yml
files into the root filesystem of the container.Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works./changelog/fragments
using the changelog tool[ ] I have added an integration test or an E2E testHow to test this PR locally
In another shell with the container running verify that the
status
command works.