Add ability to escape variable expansion in policy #5035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakerouse
added
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
|
Seems SonarQube is mad about the generated code from antlr, not from the code added. |
|
I'm okay with force merging this if we are getting the approval from code reviewer, @ycombinator is probably sharing my thoughts here |
michel-laterman
approved these changes
Jul 2, 2024
| func (v *expVisitor) VisitExpEVariable(ctx *parser.ExpEVariableContext) interface{} { | ||
| // escaped variables are not allowed in Eql conditions | ||
| // they should be wrapped in a constant to be allowed as a valid string in the expression | ||
| v.err = errors.New("escaped variable $${ is not allowed") |
There was a problem hiding this comment.
(nitpick) Would this error message be clear in the logs that this is not allowed in a condition?
There was a problem hiding this comment.
Yes the condition checker adds that context.
|
Force merging as this PR contains a lot of generated code and SonarQube is not able to exclude it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the ability to a variable not be expanded and replaced in inputs.
A variable that is defined as
$${...}will be replaced with${...}in the policy.$${...}is not allowed in anyconditionstatement, because a condition statement requires that strings always be wrapped in'...'and so it doesn't make sense to allow it to be escaped and converted into a real string. That is already supported by just doing'${...}'.Why is it important?
Allows users to provide values that should not be replaced in the policy.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E test(unit test coverage is really good)Disruptive User Impact
Adds the ability of users to escape variables.
Related issues