Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the complete image for Wolfi #5563

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix the complete image for Wolfi #5563

merged 1 commit into from
Sep 19, 2024

Conversation

rdner
Copy link
Member

@rdner rdner commented Sep 19, 2024 •
edited
Loading

There was a missed rename in #5557

Testing:

PLATFORMS=linux/arm64 PACKAGES=docker mage package

Then get shell and check the dependencies for Synthetics are there:

docker run -it --rm --entrypoint bash docker.elastic.co/beats/elastic-agent-complete-wolfi:9.0.0
ls -lah ~/.npm/bin

@rdner
Fix the complete image for Wolfi
88b449a 
There was a missed rename in elastic#5557
@rdner rdner added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team skip-changelog backport-8.x Automated backport to the 8.x branch with mergify labels Sep 19, 2024
@rdner rdner self-assigned this Sep 19, 2024
@rdner rdner requested a review from a team as a code owner September 19, 2024 13:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

blakerouse
blakerouse approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pierrehilbert
Copy link
Contributor

Force merging as last piece for #5557

@pierrehilbert pierrehilbert merged commit 808d28e into elastic:main Sep 19, 2024
12 of 17 checks passed
mergify bot pushed a commit that referenced this pull request Sep 19, 2024
@rdner @mergify
Fix the complete image for Wolfi (#5563)
a384374 
There was a missed rename in #5557

(cherry picked from commit 808d28e)
@rdner rdner deleted the fix-complete-wolfi-image-build branch September 19, 2024 16:30
ycombinator pushed a commit that referenced this pull request Sep 19, 2024
@mergify @rdner
Fix the complete image for Wolfi (#5563) (#5566)
b58197d 
There was a missed rename in #5557

(cherry picked from commit 808d28e)

Co-authored-by: Denis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@blakerouse blakerouse blakerouse approved these changes

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@rdner rdner

Labels
backport-8.x Automated backport to the 8.x branch with mergify skip-changelog Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rdner @elasticmachine @pierrehilbert @blakerouse