feat: implement custom mockes and drop go-metrics

[kruskall]

What does this PR do?

implement a custom mockes and get rid of go-metrics and related deps

Why is it important?

go-metrics hasn't been updated in 4 years

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in ./changelog/fragments using the changelog tool
• I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Blocked by elastic/mock-es#9

Questions to ask yourself

• How are we going to support this in production?
• How are we going to measure its adoption?
• How are we going to debug this?
• What are the metrics I should take care of?
• ...

[mergify]

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

[mergify]

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/custom-mockes upstream/feat/custom-mockes
git merge upstream/main
git push upstream feat/custom-mockes

[leehinman]

If the fact that go-metrics hasn't been updated in 4 years is really the "problem", can you please just propose a fix in the mock-es repo?

mocking elasticsearch is complicated enough (magic headers, license format, UUID requirements, etc) that I really don't want to see this duplicated all over the place in our testing code.

[elasticmachine]

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

[blakerouse]

I agree with @leehinman on this one. This is drastically increasing the test logic, when it was much simpler.

Another question is it not being updated an issue? Does it have a CVE or something in it that requires it to be updated?

[kruskall]

Thank you for the feedback! 🙇

I've opened another PR to replace go-metrics with otel: elastic/mock-es#9

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/custom-mockes upstream/feat/custom-mockes
git merge upstream/main
git push upstream feat/custom-mockes

[leehinman]

@kruskall I finally got your changes merged to mock-es, do you want to close this PR or re-work it to pull in new mock-es?

[kruskall]

PR updated, unfortunately now that beats is a dependency the mod graph is a mess 🥲

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube