Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore env.sh generated by mage integration:*EnvFile #5911

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

AndersonQ
Copy link
Member

What does this PR do?

Ignores the env.sh generated by mage integration:*EnvFile

Why is it important?

to avoid cloud credentials to be committed by mistake

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

  • N/A

How to test this PR locally

Run either

mage integration:generateEnvFile
mage integration:deployEnvFile

check git status

git status

it hsould not show env.sh as a new untracked file

Related issues

  • N/A

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@AndersonQ AndersonQ added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog labels Nov 1, 2024
@AndersonQ AndersonQ self-assigned this Nov 1, 2024
@AndersonQ AndersonQ requested a review from a team as a code owner November 1, 2024 10:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Contributor

mergify bot commented Nov 1, 2024

This pull request does not have a backport label. Could you fix it @AndersonQ? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Nov 1, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 1, 2024
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@AndersonQ AndersonQ merged commit 9d7fefa into elastic:main Nov 1, 2024
12 checks passed
@AndersonQ AndersonQ deleted the ignore-env-file branch November 1, 2024 11:24
@AndersonQ AndersonQ added the backport-8.16 Automated backport with mergify label Nov 1, 2024
mergify bot pushed a commit that referenced this pull request Nov 1, 2024
mergify bot pushed a commit that referenced this pull request Nov 1, 2024
AndersonQ added a commit that referenced this pull request Nov 1, 2024
(cherry picked from commit 9d7fefa)

Co-authored-by: Anderson Queiroz <[email protected]>
AndersonQ added a commit that referenced this pull request Nov 1, 2024
(cherry picked from commit 9d7fefa)

Co-authored-by: Anderson Queiroz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants