-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore env.sh generated by mage integration:*EnvFile #5911
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This pull request does not have a backport label. Could you fix it @AndersonQ? 🙏
|
|
Quality Gate passedIssues Measures |
(cherry picked from commit 9d7fefa)
(cherry picked from commit 9d7fefa)
(cherry picked from commit 9d7fefa) Co-authored-by: Anderson Queiroz <[email protected]>
(cherry picked from commit 9d7fefa) Co-authored-by: Anderson Queiroz <[email protected]>
What does this PR do?
Ignores the env.sh generated by mage integration:*EnvFile
Why is it important?
to avoid cloud credentials to be committed by mistake
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragments
using the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
How to test this PR locally
Run either
check git status
it hsould not show
env.sh
as a new untracked fileRelated issues
Questions to ask yourself