Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16](backport #5909) Trim spaces and add unit tests for cli.confirm function #5917

Open
wants to merge 1 commit into
base: 8.16
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 1, 2024

⚠️ Do NOT merge before 8.16.0 has been released ⚠️

What does this PR do?

This PR trims spaces in the user input accepted by the cli.confirm function. It also adds unit tests for this function.

Why is it important?

To ensure that yes-no confirmation prompts offered by Agent on the CLI work against user input as expected.


This is an automatic backport of pull request #5909 done by [Mergify](https://mergify.com).

* Add unit test for cli.confirm function

* Trim spaces

* Add license header

* Adding CHANGELOG entry

* Reorder imports

* Refactoring

(cherry picked from commit d39b248)
@mergify mergify bot requested a review from a team as a code owner November 1, 2024 17:05
@mergify mergify bot added the backport label Nov 1, 2024
@mergify mergify bot requested review from kaanyalti and michel-laterman and removed request for a team November 1, 2024 17:05
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant