Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config to reflect degrade_on_partial #6640

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VihasMakwana
Copy link
Contributor

@VihasMakwana VihasMakwana commented Jan 30, 2025

elastic/beats#42160 added the ability to mark metricset as degraded when partial metrics are encountered. As per this discussion, it didn't really make sense to document this behaviour on beats repo, as this option is only usable while running elastic-agent.

Until now, we weren't marking metricsets as degraded due to various hidden bugs encountered and CI failures on agent.
The plan is to enable this in agent integration test cases in elastic-agent. Once we're confident enough, we will enable this feature by default in beats and eventually, remove the flag.

This PR updates the reference file with the necessary information about the config.

Simultaneously, I've opened a PR to update system integration to reflect the changes on UI.

@VihasMakwana VihasMakwana added the enhancement New feature or request label Jan 30, 2025
@VihasMakwana VihasMakwana self-assigned this Jan 30, 2025
Copy link
Contributor

mergify bot commented Jan 30, 2025

This pull request does not have a backport label. Could you fix it @VihasMakwana? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jan 30, 2025

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 30, 2025
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@VihasMakwana VihasMakwana changed the title chore: update config to reflect degrade_on_partial Update config to reflect degrade_on_partial Jan 30, 2025
@VihasMakwana VihasMakwana marked this pull request as ready for review January 30, 2025 13:59
@VihasMakwana VihasMakwana requested a review from a team as a code owner January 30, 2025 13:59
@swiatekm swiatekm added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jan 30, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants