fix(interactions): line cursor above the chart, band cursor below #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
bug
markov00
changed the title
3 tasks
rshen91
approved these changes
Nov 2, 2021
nickofthyme
approved these changes
Nov 2, 2021
nickofthyme
pushed a commit
to nickofthyme/elastic-charts
that referenced
this pull request
Nov 2, 2021
nickofthyme
added a commit
that referenced
this pull request
Nov 2, 2021
nickofthyme
pushed a commit
that referenced
this pull request
Nov 2, 2021
## [38.0.2](v38.0.1...v38.0.2) (2021-11-02) ### Bug Fixes * **interactions:** line cursor above the chart, band cursor below ([#1453](#1453)) ([#1457](#1457)) ([ca004a6](ca004a6)) * **theme:** merge partial with empty initial partial ([#1452](#1452)) ([#1454](#1454)) ([2eadc71](2eadc71)) * **xy:** show mouse cursors on charts with opaque background ([#1447](#1447)) ([#1455](#1455)) ([b416ed5](b416ed5))
nickofthyme
pushed a commit
that referenced
this pull request
Nov 3, 2021
|
🎉 This PR is included in version 38.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The effort to fix the visibility of mouse cursors above or below the chart, started in #1447, is now completed thanks to this PR.
I've splitter the crosshair component into two components: one for the mouse cursor line (that needs to be shown above every element on the chart), and the cursor band, which needs to be shown below the chart geometries.
The crossline (the horizontal line) is also extracted and rendered separately above the chart.
related to elastic/kibana#116754
Details
The current implementation uses the calculated
zIndexto position the Crosshair component above the chart if we are rendering a line, or below if we are rendering a band.Due to some changes in the Kibana instance and a possible bug in the calculation of the chart
zIndexthe Crosshair component is always rendered in Kibana with azIndexof 0, causing it to be rendered always below the chart.A first fix went in thanks to #1447, which removes the background color applied to the
canvaselement making the cursor visible, but the problem is that the visibility is obfuscated by the gridlines.This PR fixes it removing the need of using a
zIndexto position the cursor above or below the chartIssues
fix #1283
Checklist
:xy,:partition):interactions,:axis)dark,light,eui-dark&eui-light